Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add chrislf to maintainers #79163

Closed

Conversation

@chrislf
Copy link

chrislf commented Feb 3, 2020

Motivation for this change

Adding myself to the maintainers list for forthcoming contributions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Alma Cemerlic and others added 2 commits Jan 31, 2020
@danbst
Copy link
Contributor

danbst commented Feb 14, 2020

I welcome your commitment! I'll gladly merge this together with your first maintained package.

@veprbl veprbl changed the title Wq maintainers chrislintonford [WIP] add chrislf to maintainers May 1, 2020
@doronbehar
Copy link
Contributor

doronbehar commented May 23, 2020

@chrislf welcome aboard.

  1. You should respond somehow (either via comments or a git push) to comments & reviews from reviewers :).
  2. I haven't searched if you have contributed something to Nixpkgs but following @danbst's comment, usually 1st time PRs of new maintainers include the commits:
maintainers: add chrislf
<package-attr>: init at <version>

So there's no need to create separate PRs for each of these commits.

  1. You should make sure your git commits are associated with your email address on your GitHub account and I'd recommend that the same email address will be used in the maintainers-list.nix file. This makes it GitHub link your commits (if ever browsed on the web interface) to your account. Perhaps this will help: https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address

I'm closing this PR in favor of a future contribution 🚀.

Regards.

@doronbehar doronbehar closed this May 23, 2020
@chrislf
Copy link
Author

chrislf commented May 23, 2020

Apologies @doronbehar and @danbst : I did not get any contributions prepared to a standard worth submitting since the initial PR. I will do so before asking to be added again.
Thank you both for taking the time to respond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.