Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
WIP: gettext: refactor and split in multiple packages #79171
Motivation for this change
This PR solves #73288
Following upstream recommendations, gettext is split into 3 distinct
Given that for each sub-package we use
For the time being,
A tree-wide update could be tried to replace all occurances of a
I am also very open to discussions on how I did implement the 3 packages that share 1 source tarball.
If we are too close to the last staging changes before release-20.03, I have no problem to postpone this MR (cc @FRidh ).
@jtojnar thanks for the review
I am so ashamed of the number of of typos I did let through…
I am rebuilding everything to test at the moment. I’ll push when I have checked that it builds properly.
I have also ported some modifications you suggested from
Yes, some packages build do require (explicitly)
Do we have a simple way to have a “old style”
I am not sure of a nice way to approach that
Following upstream recommendations, gettext is split into 3 distinct packages: - gettext-runtime - gettext-tools - libtextstyle See https://git.savannah.gnu.org/gitweb/?p=gettext.git;a=blob;f=PACKAGING;h=f4bae4561ec70a9de2532502b5c2358bb976036c;hb=55b8fe9a2f12b22eb3ee6baf973e03e60b3a9915 Given that for each sub-package we use `sourceRoot`, the patches do not apply directly when fetch from upstream git and have to be editted to strip the top level dir. For the time being, `gettext` is turned into an alias to `gettext-runtime` to ease transition.
Hello, I'm a bot and I thank you in the name of the community for your contributions.
Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.
If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:
If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.
If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.
If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.