Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xorg.libXft: add color emoji rendering support #79176

Merged
merged 1 commit into from Feb 5, 2020

Conversation

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 3, 2020

https://gitlab.freedesktop.org/xorg/lib/libxft/merge_requests/1

Motivation for this change

Fixes #69073

Things done

Haven't tested against an actual package, but it builds.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace worldofpeace requested a review from jtojnar Feb 3, 2020
@worldofpeace worldofpeace added this to the 20.03 milestone Feb 3, 2020
@jtojnar
jtojnar approved these changes Feb 3, 2020
Copy link
Contributor

@jtojnar jtojnar left a comment

Hopefully, it fixes the crash.

@dasJ
Copy link
Member

@dasJ dasJ commented Feb 3, 2020

@jtojnar It does mostly. But sometimes (for example when printing localized files with weird characters), it still crashes (happens about once or twice per week)

@dasJ
Copy link
Member

@dasJ dasJ commented Feb 3, 2020

Looks like that:
image

@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Feb 5, 2020

FWIW, someone on the upstream issue mentioned that this change breaks some fallback behavior re:glyphs not in base font (CJK, often): https://gitlab.freedesktop.org/xorg/lib/libxft/merge_requests/1#note_402043 .

I haven't tested this, just wanted to make sure this wasn't missed (if indeed an issue for us).

Otherwise, looking forward to emoji color goodness in libXft soon! :)

@FRidh FRidh added this to WIP in Staging via automation Feb 5, 2020
@FRidh FRidh changed the base branch from master to staging Feb 5, 2020
@FRidh FRidh changed the base branch from staging to master Feb 5, 2020
@FRidh FRidh changed the base branch from master to staging Feb 5, 2020
@FRidh FRidh merged commit cf83cfb into NixOS:staging Feb 5, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
xorg.libXft on aarch64-linux Success
Details
xorg.libXft on x86_64-darwin Success
Details
xorg.libXft on x86_64-linux Success
Details
Staging automation moved this from WIP to Done Feb 5, 2020
@worldofpeace worldofpeace deleted the worldofpeace:libxft-patch-bgra branch Feb 5, 2020
@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Feb 5, 2020

Thanks @FRidh for integrating this and so many other changes ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.