Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ifmetric: init at 0.3 #79186

Merged
merged 1 commit into from Aug 10, 2020
Merged

ifmetric: init at 0.3 #79186

merged 1 commit into from Aug 10, 2020

Conversation

@anna328p
Copy link
Member

@anna328p anna328p commented Feb 3, 2020

Motivation for this change

Adds ifmetric, a tool for setting network interface metrics, to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 17, 2020

@anna328p anna328p force-pushed the anna328p:ifmetric branch from bb8a2fe to f79a0a8 Mar 30, 2020
@anna328p
Copy link
Member Author

@anna328p anna328p commented Mar 30, 2020

Copy link
Contributor

@jonringer jonringer left a comment

otherwise LGTM

pkgs/os-specific/linux/ifmetric/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/ifmetric/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@anna328p anna328p force-pushed the anna328p:ifmetric branch from f79a0a8 to 01842ed Jul 16, 2020
@anna328p
Copy link
Member Author

@anna328p anna328p commented Jul 16, 2020

Rebased on latest master.

@anna328p anna328p force-pushed the anna328p:ifmetric branch from 01842ed to ed4f194 Jul 16, 2020
@anna328p
Copy link
Member Author

@anna328p anna328p commented Jul 16, 2020

@jonringer I have addressed all of your comments and updated the commit.

@anna328p anna328p force-pushed the anna328p:ifmetric branch from ed4f194 to 7ecb6c3 Jul 29, 2020
@anna328p anna328p force-pushed the anna328p:ifmetric branch from 7ecb6c3 to bba8707 Jul 29, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/79186
1 package built:
ifmetric

looks to be largely unmaintained, but I don't see any more "up-to-date" alternatives

@jonringer jonringer merged commit 0500296 into NixOS:master Aug 10, 2020
17 checks passed
17 checks passed
tests
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bba8707"; rev="bba87076b9df87d14e714547918f22200eb18889"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bba8707"; rev="bba87076b9df87d14e714547918f22200eb18889"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bba8707"; rev="bba87076b9df87d14e714547918f22200eb18889"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bba8707"; rev="bba87076b9df87d14e714547918f22200eb18889"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bba8707"; rev="bba87076b9df87d14e714547918f22200eb18889"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bba8707"; rev="bba87076b9df87d14e714547918f22200eb18889"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bba8707"; rev="bba87076b9df87d14e714547918f22200eb18889"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ifmetric, ifmetric.passthru.tests on aarch64-linux Success
Details
ifmetric, ifmetric.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.