Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS cli session manager plugin v1.1.54.0 #79195

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@nikuda
Copy link
Contributor

@nikuda nikuda commented Feb 4, 2020

Motivation for this change

Added AWS cli plugin Session Manager as a package
https://docs.aws.amazon.com/systems-manager/latest/userguide/session-manager-working-with-install-plugin.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lexun
Copy link

@lexun lexun commented Jun 10, 2020

Is this covered by #87165?

@nikuda
Copy link
Contributor Author

@nikuda nikuda commented Jun 18, 2020

@lexun Mostly, the difference is this one works on Mac, so some of the things here can be moved to the other PR but other PR is more complete.

nbr added a commit to BookBub/nixpkgs that referenced this pull request Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.