Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesos: fix insecure domain #79228

Closed
wants to merge 453 commits into from
Closed

mesos: fix insecure domain #79228

wants to merge 453 commits into from

Conversation

@jpgu-epam
Copy link

@jpgu-epam jpgu-epam commented Feb 4, 2020

Motivation for this change

Maven insecure domain was changed in favor of https.
Closes: #78702

Things done

Fix maven domain for mesos derivation

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
ggreif and others added 30 commits Jan 25, 2020
Previously the package conf files were handled without paying attention
to the fact that it's pretty-printed output. One problem was discovered
with GHC 8.8.1 on Darwin, where the dynamic-library-dirs first field
seems to have increased in length, meaning while before it was

    dynamic-library-dirs: some-small-directory-name
                          some-more-directories

Now it is

    dynamic-library-dirs:
        some-larger-directory-name
        some-more-directories

Which breaks the code installed for #25537,
because that assumed the former format, resulting in the reoccurence of
the bug in #22810, see
Infinisil/all-hies#43

This commit fixes this by "unprettyfying" the package conf files before
processing them.

Closes #78738.
This update was generated by hackage2nix v2.15.0-16-g2971916 from Hackage revision
commercialhaskell/all-cabal-hashes@d77d0f7.
University of Maryland PhD Student. Quantum Computing.
Add Google's Cirq package.
Uses: Quantum information science.
- formatting
- add wrapQtAppsHook
- use fetchFromGitHub instead of fetchurl
- don't construct name manually
- add homepage to meta
- remove repositories.get from meta
- use mkDerivation instead of stdenv.mkDerivation
- add qtwebsockets dependency
We install a polkit agent automatically no
@jpgu-epam jpgu-epam force-pushed the jpgu-epam:fork/master branch from d2ad181 to 23f802c Feb 4, 2020
@jpgu-epam jpgu-epam changed the title Fork/master mesos: fix insecure domain Feb 4, 2020
@jpgu-epam jpgu-epam closed this Feb 4, 2020
@jpgu-epam jpgu-epam deleted the jpgu-epam:fork/master branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.