Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lorri: unstable-2020-01-09 -> 1.0 #79230

Merged
merged 1 commit into from Feb 5, 2020
Merged

lorri: unstable-2020-01-09 -> 1.0 #79230

merged 1 commit into from Feb 5, 2020

Conversation

@curiousleo
Copy link
Contributor

@curiousleo curiousleo commented Feb 4, 2020

Motivation for this change

lorri has reached version 1.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" (trivial: there aren't any)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested review from Profpatsch and grahamc Feb 4, 2020
@curiousleo curiousleo marked this pull request as ready for review Feb 4, 2020
@@ -27,11 +27,11 @@ rustPlatform.buildRustPackage rec {
owner = "target";
repo = pname;
# Run `eval $(nix-build -A lorri.updater)` after updating the revision!

This comment has been minimized.

@curiousleo

curiousleo Feb 4, 2020
Author Contributor

Done.

@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Feb 4, 2020

@GrahamcOfBorg build lorri.tests

@grahamc
Copy link
Member

@grahamc grahamc commented Feb 4, 2020

lgtm, but no idea why the tests failed. Let's try again:

@GrahamcOfBorg build lorri.tests

@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Feb 4, 2020

Test fails.

@curiousleo curiousleo force-pushed the curiousleo:lorri-1.0 branch from 4349ca8 to b3c3107 Feb 5, 2020
@ofborg ofborg bot added the 6.topic: nixos label Feb 5, 2020
@curiousleo curiousleo mentioned this pull request Feb 5, 2020
1 of 3 tasks complete
@curiousleo
Copy link
Contributor Author

@curiousleo curiousleo commented Feb 5, 2020

@GrahamcOfBorg build lorri.tests

@curiousleo
Copy link
Contributor Author

@curiousleo curiousleo commented Feb 5, 2020

Test passes. Sorry I forgot to update it before! I've amended the publishing procedure accordingly: target/lorri#326

Copy link
Member

@Profpatsch Profpatsch left a comment

Great to see 1.0!! Thanks @curiousleo @grahamc for your tireless work.

@Profpatsch Profpatsch merged commit 42a2668 into NixOS:master Feb 5, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
lorri on aarch64-linux Success
Details
lorri on x86_64-linux Success
Details
lorri.tests on aarch64-linux Success
Details
lorri.tests on x86_64-linux Success
Details
@curiousleo curiousleo deleted the curiousleo:lorri-1.0 branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.