Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpkgs/brlaser: upgrade to v6 #79246

Merged
merged 1 commit into from Apr 18, 2020
Merged

nixpkgs/brlaser: upgrade to v6 #79246

merged 1 commit into from Apr 18, 2020

Conversation

@jakubgs
Copy link
Contributor

@jakubgs jakubgs commented Feb 5, 2020

Why

It introduces support for several additional Brother printers:

Brother HL-2030 series
Brother HL-2140 series
Brother HL-2220 series
Brother HL-2270DW series
Brother HL-5030 series
Brother DCP-L2520D series

https://github.com/pdewacht/brlaser/releases/tag/v6

Testing

I've tested this on Linux with HL-2140 and it works without any issues.

Notify maintainers

@StijnDW

It introduces support for several additional Brother printers.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@StijnDW
StijnDW approved these changes Feb 9, 2020
Copy link
Contributor

@StijnDW StijnDW left a comment

Thanks for the pr :)

@jakubgs
Copy link
Contributor Author

@jakubgs jakubgs commented Feb 10, 2020

What's missing to merge this?

@jakubgs
Copy link
Contributor Author

@jakubgs jakubgs commented Feb 12, 2020

Do we need another reviewer?

@StijnDW
Copy link
Contributor

@StijnDW StijnDW commented Feb 12, 2020

Nothing is missing as far as I know.
Someone from the Nixpkgs committers team will merge this when they have time.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Apr 17, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/19

@bhipple
Copy link
Contributor

@bhipple bhipple commented Apr 18, 2020

Result of nixpkgs-review pr 79246 1

1 package built:
- brlaser
@bhipple bhipple merged commit 78760d1 into NixOS:master Apr 18, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@bhipple
Copy link
Contributor

@bhipple bhipple commented Apr 18, 2020

LGTM, despite the "major version" upgrade the changelog appears to imply just adding new features, and it has no reverse dependencies, so 👍

EDIT: Didn't notice this initially, but for future reference the commit subject and PR title should be:

brlaser: 5 -> 6

Per guidelines on https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.