Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-cloud-sdk: reduce output size #79250

Merged
merged 4 commits into from Feb 5, 2020
Merged

google-cloud-sdk: reduce output size #79250

merged 4 commits into from Feb 5, 2020

Conversation

@edef1c
Copy link
Member

@edef1c edef1c commented Feb 5, 2020

Motivation for this change

Together, these changes reduce output size by 27% (45.5 MiB).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
edef1c added 4 commits Jan 30, 2020
Both third_party/crcmod_osx and third_party/crcmod are only used in the
PYTHONPATH, and we already replace them with dependencies from nixpkgs.
This reduces output size by 4.5 MiB.
This reduces output size by 20 MiB.
This reduces output size by 21 MiB.
@flokli
flokli approved these changes Feb 5, 2020
@flokli flokli merged commit 873e6a4 into NixOS:master Feb 5, 2020
16 checks passed
16 checks passed
google-cloud-sdk on aarch64-linux No attempt
Details
google-cloud-sdk on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
google-cloud-sdk on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@edef1c edef1c deleted the edef1c:gcloud-sdk-size branch Feb 5, 2020
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Feb 5, 2020
google-cloud-sdk: reduce output size
(cherry picked from commit 873e6a4)
@edef1c edef1c mentioned this pull request Feb 13, 2020
5 of 8 tasks complete
@macalinao

This comment has been minimized.

Copy link

@macalinao macalinao commented on 6ceebc4 Feb 15, 2020

This breaks the build on osx

This comment has been minimized.

Copy link
Member Author

@edef1c edef1c replied Feb 18, 2020

We can disable this on macOS if need be, but it's unclear to me why strip(1) doesn't work on macOS — despite the file extension, there's a perfectly fine macOS dylib at that path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.