Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hover: init 2020-01-23 #79252

Closed
wants to merge 1 commit into from
Closed

Conversation

@ericdallo
Copy link
Contributor

ericdallo commented Feb 5, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Feb 5, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/help-wanted-hover-for-flutter-desktop/5755/1

@ofborg ofborg bot requested a review from ehmry Feb 5, 2020
@ericdallo ericdallo mentioned this pull request Feb 5, 2020
5 of 10 tasks complete
@ofborg ofborg bot added the 6.topic: golang label Feb 6, 2020
@ofborg ofborg bot requested a review from kalbasit Feb 6, 2020
@ericdallo ericdallo force-pushed the ericdallo:add-hover-flutter branch 2 times, most recently from d9cceca to 422264e Feb 6, 2020
@ericdallo ericdallo force-pushed the ericdallo:add-hover-flutter branch 2 times, most recently from aa2efee to 7091890 Feb 6, 2020
@ofborg ofborg bot removed the 6.topic: golang label Feb 6, 2020
@ericdallo ericdallo force-pushed the ericdallo:add-hover-flutter branch 2 times, most recently from 19b85a4 to 6f87491 Feb 6, 2020
@ericdallo ericdallo force-pushed the ericdallo:add-hover-flutter branch from 6f87491 to 24aeeb3 Feb 14, 2020
@ericdallo ericdallo force-pushed the ericdallo:add-hover-flutter branch from 24aeeb3 to e6e1bec Feb 14, 2020
@ericdallo ericdallo force-pushed the ericdallo:add-hover-flutter branch from e6e1bec to 934562c Feb 14, 2020
@ericdallo

This comment has been minimized.

Copy link
Contributor Author

ericdallo commented Feb 14, 2020

Done in PR: #80075

@ericdallo ericdallo closed this Feb 14, 2020
@ericdallo ericdallo deleted the ericdallo:add-hover-flutter branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.