Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.flower: init at 0.9.3 #79279

Merged
merged 1 commit into from Feb 9, 2020
Merged

pythonPackages.flower: init at 0.9.3 #79279

merged 1 commit into from Feb 9, 2020

Conversation

@arnoldfarkas
Copy link
Contributor

@arnoldfarkas arnoldfarkas commented Feb 5, 2020

Motivation for this change

Packaging Python module flower in Nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@FRidh
Copy link
Member

@FRidh FRidh commented Feb 5, 2020

Please group related commits in a single PR which is not too big (say not more than 15 packages).

@FRidh
Copy link
Member

@FRidh FRidh commented Feb 5, 2020

Also, note not every package needs to be in Nixpkgs. The purpose of Nixpkgs is to have packages that are likely to be used by a portion of our userbase. Python packages are relatively time-consuming to maintain in Nixpkgs, so think about whether it makes sense to include them in Nixpkgs, or whether you can keep the expressions elsewhere.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 6, 2020

I asked him to split the 25 package pr into individual PRs because it would be too time consuming to comment on one PR and have a change of merging it before it was ready.

I haven't had time to review it, but I'm concerned about the lack of unit tests, and the source isn't freely available.

@arnoldfarkas
Copy link
Contributor Author

@arnoldfarkas arnoldfarkas commented Feb 7, 2020

Well, the author of qiskit is not me - so I wonder about what is the optimal granularity of PRs: probably when I need to add a package because it is a missing dependency, those packages might go in one PR. The largest number I saw so far was 5, that is probably reasonable - and I am adding test, if only GitHub has not PyPI it then I use GitHub, unless the source cannot be built from there in which case I fetch both: build PyPI and copy test over in the patch phase. This way I can add tests if those are available.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 7, 2020

wish I had more time to review, visiting family.

@FRidh
Copy link
Member

@FRidh FRidh commented Feb 9, 2020

@GrahamcOfBorg build python3Packages.flower

@FRidh FRidh merged commit 500a8ff into NixOS:master Feb 9, 2020
15 of 16 checks passed
15 of 16 checks passed
python3Packages.flower on aarch64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python3Packages.flower on x86_64-darwin Success
Details
python3Packages.flower on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.