Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hey: init at 0.1.3 #79281

Merged
merged 1 commit into from Feb 26, 2020
Merged

hey: init at 0.1.3 #79281

merged 1 commit into from Feb 26, 2020

Conversation

@Br1ght0ne
Copy link
Contributor

@Br1ght0ne Br1ght0ne commented Feb 5, 2020

Motivation for this change

https://github.com/rakyll/hey/releases/tag/v0.1.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

Copy link
Member

@Frostman Frostman left a comment

nixpkgs-review passed ok, binary works correctly.

pkgs/tools/networking/hey/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/hey/default.nix Outdated Show resolved Hide resolved
@Br1ght0ne Br1ght0ne force-pushed the Br1ght0ne:hey-0.1.3 branch from e19e3b0 to 25646ea Feb 10, 2020
@Br1ght0ne Br1ght0ne requested a review from Frostman Feb 10, 2020
@Frostman
Copy link
Member

@Frostman Frostman commented Feb 10, 2020

Change LGTM, verified with nixpkgs-review, binary works correctly (NixOS, x86_64). Thank you!

Copy link
Member

@yegortimoshenko yegortimoshenko left a comment

LGTM otherwise!

pkgs/tools/networking/hey/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/hey/default.nix Outdated Show resolved Hide resolved
@Br1ght0ne Br1ght0ne force-pushed the Br1ght0ne:hey-0.1.3 branch from 25646ea to 180b61b Feb 26, 2020
@Br1ght0ne Br1ght0ne requested a review from yegortimoshenko Feb 26, 2020
@Br1ght0ne
Copy link
Contributor Author

@Br1ght0ne Br1ght0ne commented Feb 26, 2020

@yegortimoshenko
Copy link
Member

@yegortimoshenko yegortimoshenko commented Feb 26, 2020

@GrahamcOfBorg build hey

@yegortimoshenko yegortimoshenko merged commit d7a0351 into NixOS:master Feb 26, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
hey on aarch64-linux Success
Details
hey on x86_64-darwin Success
Details
hey on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.