Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isArm #79291

Merged
merged 3 commits into from Feb 8, 2020
Merged

Remove isArm #79291

merged 3 commits into from Feb 8, 2020

Conversation

@chkno
Copy link
Member

@chkno chkno commented Feb 5, 2020

Motivation for this change

isArm has been deprecated for three releases. All references have been removed. Tree-wide substitution was performed in #37401 21 months ago.

The noisy isArm alias causes maintainers/scripts/find-tarballs.nix to generate spurious warnings as it recurses through.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
chkno added 3 commits Feb 5, 2020
This is the last package reference to isArm.  isArm is deprecated after 18.03.
This substitution was performed tree-wide in #37401.
This is the last reference to isArm.  isArm is deprecated after 18.03.
This substitution was performed tree-wide in #37401.
isArm has been deprecated for three releases.  All references have been
removed.  Tree-wide substitution was performed in #37401 21 months ago.
@chkno chkno requested review from Ericson2314, matthewbauer and nbp as code owners Feb 5, 2020
@ofborg ofborg bot added the 6.topic: stdenv label Feb 5, 2020
@chkno
Copy link
Member Author

@chkno chkno commented Feb 5, 2020

(GitHub's web UI is displaying these commits in the wrong order. This is GitHub issue #386. The actual order is visible on this branch's commits page.)

@FRidh FRidh added this to the 20.03 milestone Feb 5, 2020
Copy link
Member

@worldofpeace worldofpeace left a comment

LGTM

@worldofpeace worldofpeace merged commit 1193468 into NixOS:master Feb 8, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nodejs, stdenv on aarch64-linux Success
Details
nodejs, stdenv on x86_64-linux Success
Details
@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Feb 8, 2020

Glad to see this saga concluded :)

dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Feb 8, 2020
Remove isArm

(cherry picked from commit 1193468)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.