Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.arcanist-vim: init at 2016-05-27 #79312

Merged
merged 4 commits into from Feb 12, 2020

Conversation

@lovesegfault
Copy link
Contributor

@lovesegfault lovesegfault commented Feb 6, 2020

Motivation for this change

I noticed it was missing, also noticed the list was out of ordered and added a commit sorting it again.

Edit
I also added https://github.com/jparise/vim-phabricator

@jonringer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lovesegfault lovesegfault requested a review from jonringer as a code owner Feb 6, 2020
@ofborg ofborg bot added the 6.topic: vim label Feb 6, 2020
@lovesegfault
Copy link
Contributor Author

@lovesegfault lovesegfault commented Feb 6, 2020

[61 built, 105 copied (1017.4 MiB), 228.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79312
30 package built:
vimPlugins.arcanist-vim vimPlugins.coc-git vimPlugins.coc-go vimPlugins.coc-yaml vimPlugins.csv vimPlugins.denite vimPlugins.deoplete-jedi vimPlugins.falcon vimPlugins.fastfold vimPlugins.fugitive vimPlugins.fzf-vim vimPlugins.jedi-vim vimPlugins.lh-brackets vimPlugins.lightline-vim vimPlugins.ncm2 vimPlugins.ncm2-jedi vimPlugins.neomake vimPlugins.neomru vimPlugins.nvim-lsp vimPlugins.quickrun vimPlugins.rust-vim vimPlugins.vim-asterisk vimPlugins.vim-autoformat vimPlugins.vim-devicons vimPlugins.vim-go vimPlugins.vim-gutentags vimPlugins.vim-parinfer vimPlugins.vim-sandwich vimPlugins.vim-snippets vimPlugins.vista-vim
@lovesegfault
Copy link
Contributor Author

@lovesegfault lovesegfault commented Feb 8, 2020

After rebasing and re-updating today

[70 built, 16 copied (2.6 MiB), 0.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79312
62 package built:
vimPlugins.nerdtree vimPlugins.airline vimPlugins.ale vimPlugins.arcanist-vim vimPlugins.calendar vimPlugins.coc-eslint vimPlugins.coc-git vimPlugins.coc-go vimPlugins.coc-metals vimPlugins.coc-tsserver vimPlugins.coc-yaml vimPlugins.csv vimPlugins.ctrlp vimPlugins.denite vimPlugins.deoplete-jedi vimPlugins.easymotion vimPlugins.falcon vimPlugins.fastfold vimPlugins.fugitive vimPlugins.fzf-vim vimPlugins.jedi-vim vimPlugins.lh-brackets vimPlugins.lightline-vim vimPlugins.multiple-cursors vimPlugins.ncm2 vimPlugins.ncm2-jedi vimPlugins.neomake vimPlugins.neomru vimPlugins.neosnippet vimPlugins.nvim-lsp vimPlugins.open-browser vimPlugins.open-browser-github-vim vimPlugins.quickrun vimPlugins.rust-vim vimPlugins.snipmate vimPlugins.unicode-vim vimPlugins.vim-addon-actions vimPlugins.vim-addon-background-cmd vimPlugins.vim-addon-goto-thing-at-cursor vimPlugins.vim-addon-mru vimPlugins.vim-addon-mw-utils vimPlugins.vim-addon-nix vimPlugins.vim-addon-other vimPlugins.vim-addon-syntax-checker vimPlugins.vim-addon-toggle-buffer vimPlugins.vim-addon-xdebug vimPlugins.vim-airline-themes vimPlugins.vim-asterisk vimPlugins.vim-autoformat vimPlugins.vim-devicons vimPlugins.vim-go vimPlugins.vim-gutentags vimPlugins.vim-parinfer vimPlugins.vim-phabricator vimPlugins.vim-racer vimPlugins.vim-sandwich vimPlugins.vim-snippets vimPlugins.vim-terraform vimPlugins.vim-themis vimPlugins.vim-wakatime vimPlugins.vista-vim vimPlugins.xptemplate
@lovesegfault lovesegfault force-pushed the lovesegfault:vim-plugins-arcanist branch 2 times, most recently from c60e5d5 to 50ac105 Feb 10, 2020
@lovesegfault
Copy link
Contributor Author

@lovesegfault lovesegfault commented Feb 10, 2020

de-novo

[19 built, 69 copied (368.3 MiB), 78.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79312
68 package built:
vimPlugins.nerdtree vimPlugins.YouCompleteMe vimPlugins.airline vimPlugins.ale vimPlugins.ansible-vim vimPlugins.arcanist-vim vimPlugins.calendar vimPlugins.coc-eslint vimPlugins.coc-git vimPlugins.coc-go vimPlugins.coc-metals vimPlugins.coc-tsserver vimPlugins.coc-yaml vimPlugins.csv vimPlugins.ctrlp vimPlugins.defx-nvim vimPlugins.denite vimPlugins.deoplete-jedi vimPlugins.easymotion vimPlugins.falcon vimPlugins.fastfold vimPlugins.ferret vimPlugins.fugitive vimPlugins.fzf-vim vimPlugins.jedi-vim vimPlugins.lh-brackets vimPlugins.lightline-vim vimPlugins.multiple-cursors vimPlugins.ncm2 vimPlugins.ncm2-jedi vimPlugins.neomake vimPlugins.neomru vimPlugins.neosnippet vimPlugins.nvim-gdb vimPlugins.nvim-lsp vimPlugins.open-browser vimPlugins.open-browser-github-vim vimPlugins.quickrun vimPlugins.rust-vim vimPlugins.snipmate vimPlugins.unicode-vim vimPlugins.vim-addon-actions vimPlugins.vim-addon-background-cmd vimPlugins.vim-addon-goto-thing-at-cursor vimPlugins.vim-addon-mru vimPlugins.vim-addon-mw-utils vimPlugins.vim-addon-nix vimPlugins.vim-addon-other vimPlugins.vim-addon-syntax-checker vimPlugins.vim-addon-toggle-buffer vimPlugins.vim-addon-xdebug vimPlugins.vim-airline-themes vimPlugins.vim-asterisk vimPlugins.vim-autoformat vimPlugins.vim-better-whitespace vimPlugins.vim-devicons vimPlugins.vim-go vimPlugins.vim-gutentags vimPlugins.vim-parinfer vimPlugins.vim-phabricator vimPlugins.vim-racer vimPlugins.vim-sandwich vimPlugins.vim-snippets vimPlugins.vim-terraform vimPlugins.vim-themis vimPlugins.vim-wakatime vimPlugins.vista-vim vimPlugins.xptemplate
@ofborg ofborg bot requested a review from jagajaga Feb 10, 2020
@lovesegfault
Copy link
Contributor Author

@lovesegfault lovesegfault commented Feb 10, 2020

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 12, 2020

sorry, do you mind rebasing again.

Been caught up with moving then was traveling

lovesegfault added 4 commits Feb 6, 2020
@lovesegfault lovesegfault force-pushed the lovesegfault:vim-plugins-arcanist branch from 50ac105 to 1b73226 Feb 12, 2020
@lovesegfault
Copy link
Contributor Author

@lovesegfault lovesegfault commented Feb 12, 2020

Done, @jonringer :)

Testing

@lovesegfault
Copy link
Contributor Author

@lovesegfault lovesegfault commented Feb 12, 2020

Getting a failure of an unrelated plugin:

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/bemeurer/.cache/nixpkgs-review/pr-79312-4/build.nix
builder for '/nix/store/yn670mzi6xggidlfa95zimgmlhd190nj-vimplugin-far-vim-2020-02-12.drv' failed with exit code 1; last 10 log lines:
  unpacking sources
  unpacking source archive /nix/store/ngbhjj2raj3ikvv6py4dq3nq4j4x03iy-source
  source root is source
  patching sources
  configuring
  building
  installing
  Building help tags
  Error detected while processing command line:
  E154: Duplicate tag "g:far#mapping['stoggle_expand_all']" in file /nix/store/iy7s6nplwlw9kdign5xmyyr2b9cvc8zl-vimplugin-far-vim-2020-02-12/share/vim-plugins/far-vim/doc/far.txtFailed to build help tags!
cannot build derivation '/nix/store/4mv1566gnsm9k7v5ai23sf57nx8nlac2-env.drv': 1 dependencies couldn't be built
[0 built (1 failed)]
error: build of '/nix/store/4mv1566gnsm9k7v5ai23sf57nx8nlac2-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/79312
1 package failed to build:
vimPlugins.far-vim

2 package built:
vimPlugins.arcanist-vim vimPlugins.vim-phabricator
@lovesegfault
Copy link
Contributor Author

@lovesegfault lovesegfault commented Feb 12, 2020

This patch fixes the failure, should I apply it @jonringer ?

diff --git a/pkgs/misc/vim-plugins/vim-plugin-names b/pkgs/misc/vim-plugins/vim-plugin-names
index 0fc5edffe48..3081f2383f2 100644
--- a/pkgs/misc/vim-plugins/vim-plugin-names
+++ b/pkgs/misc/vim-plugins/vim-plugin-names
@@ -30,7 +30,6 @@ bogado/file-line
 bohlender/vim-smt2
 brennanfee/vim-gui-position
 bronson/vim-trailing-whitespace
-brooth/far.vim
 carlitux/deoplete-ternjs
 ccarpita/rtorrent-syntax-file
 cespare/vim-toml
@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 12, 2020

I posted the issue here: brooth/far.vim#84 it's an upstream issue. If it lasts more than a day, I will mark it broken

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commits LGTM

failure unrelated to PR, but upstreamed: brooth/far.vim#84

[5 built (1 failed), 55 copied (274.7 MiB), 62.5 MiB DL]
error: build of '/nix/store/4mv1566gnsm9k7v5ai23sf57nx8nlac2-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/79312
1 package failed to build:
vimPlugins.far-vim

2 package built:
vimPlugins.arcanist-vim vimPlugins.vim-phabricator
@jonringer jonringer merged commit fc7f856 into NixOS:master Feb 12, 2020
14 of 15 checks passed
14 of 15 checks passed
vimPlugins.arcanist-vim, vimPlugins.vim-phabricator on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vimPlugins.arcanist-vim, vimPlugins.vim-phabricator on aarch64-linux Success
Details
@lovesegfault lovesegfault deleted the lovesegfault:vim-plugins-arcanist branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.