Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(19.09) gogs: 0.11.86 -> 0.11.91, fixes CVE-2019-14544 #79315

Merged
merged 1 commit into from Feb 6, 2020

Conversation

@Moredread
Copy link
Contributor

@Moredread Moredread commented Feb 6, 2020

(cherry picked from commit 3cd72fb)

Motivation for this change

Backport for 19.09 of PR #79314

Update and fix for CVE-2019-14544, CVSS 3 Score 9.8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
(cherry picked from commit 3cd72fb)
@Moredread Moredread requested a review from schneefux Feb 6, 2020
@Moredread
Copy link
Contributor Author

@Moredread Moredread commented Feb 6, 2020

Tested on my "production" machine

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Feb 6, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/91

@lsix
lsix approved these changes Feb 6, 2020
Copy link
Member

@lsix lsix left a comment

Built, all good for me.

Thanks.

@lsix lsix merged commit 9af8512 into NixOS:release-19.09 Feb 6, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gogs on aarch64-linux Success
Details
gogs on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@lsix
Copy link
Member

@lsix lsix commented Feb 6, 2020

Given the security fix, I am ok to port to release-19.09.

@lsix
Copy link
Member

@lsix lsix commented Feb 6, 2020

we could also have backported gogs/gogs@c3af3ff but since this is not a major update 👍

@Moredread Moredread deleted the Moredread:gogs-0.11.91-stable branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.