Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safe: init at 1.5.1 #79325

Merged
merged 1 commit into from Feb 11, 2020
Merged

safe: init at 1.5.1 #79325

merged 1 commit into from Feb 11, 2020

Conversation

@eonpatapon
Copy link
Contributor

@eonpatapon eonpatapon commented Feb 6, 2020

Motivation for this change

Provides a more user friendly cli to interact with vault

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
src = fetchFromGitHub {
owner = "starkandwayne";
repo = "safe";
rev = version;

This comment has been minimized.

@nlewo

nlewo Feb 10, 2020
Member

Suggested change
rev = version;
rev = "v${version}";

ofborg failed to download sources.

@eonpatapon eonpatapon force-pushed the eonpatapon:safe branch from 0b69e11 to dd759b3 Feb 11, 2020
@eonpatapon
Copy link
Contributor Author

@eonpatapon eonpatapon commented Feb 11, 2020

Thanks @nlewo, bad copy/paste :(

@eonpatapon eonpatapon requested a review from nlewo Feb 11, 2020
@nlewo
Copy link
Member

@nlewo nlewo commented Feb 11, 2020

@GrahamcOfBorg build safe

@nlewo nlewo merged commit 2a773b1 into NixOS:master Feb 11, 2020
3 checks passed
3 checks passed
safe on aarch64-linux Success
Details
safe on x86_64-darwin Success
Details
safe on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.