Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.perhaps: jailbreak #79330

Merged
merged 1 commit into from Feb 7, 2020

Conversation

@Taneb
Copy link
Contributor

@Taneb Taneb commented Feb 6, 2020

Motivation for this change

It has an overly tight dependency on doctest.

Things done

I've made a PR upstream too.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [ x Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@cdepillabout cdepillabout left a comment

You'll have to actually mark this as unbroken in the configuration-hackage2nix.yaml file.

I've tested that this can be built, so once you've marked this as unbroken, I will merge it in.

It has an overly tight dependency on doctest.

I've removed it from the list of broken builds in the yaml and I've made
a PR upstream too.
@Taneb Taneb force-pushed the Taneb:jailbreak-perhaps branch from 38ee45e to 66c3757 Feb 7, 2020
@Taneb
Copy link
Contributor Author

@Taneb Taneb commented Feb 7, 2020

@cdepillabout thanks for the spot, I've got allowBroken = true in my config so I missed that. I've force-pushed changing the YAML, but I'll leave the regeneration to @peti or whoever's merging haskell-updates.

@cdepillabout cdepillabout merged commit acbff77 into NixOS:haskell-updates Feb 7, 2020
1 check failed
1 check failed
grahamcofborg-eval The branch this PR will merge in to does not cleanly evaluate, and so this PR cannot be checked.
Details
@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Feb 7, 2020

Thanks for fixing this up. It should be available next time haskell-updates gets an automatic update.

perhaps looks like an interesting library, btw.

@peti
Copy link
Member

@peti peti commented Feb 7, 2020

Yeah, it looks like a typical new addition to the Kmettverse: it's simple, straight-forward, and captures a fundamental concept in a new and unique way. At the same time, it remains a complete mystery how one would ever use that library in a way that makes a practical difference compared to, say, maybe or either.

@@ -1389,4 +1389,7 @@ self: super: {
# prettyprinter-1.6.0 fails its doctest suite.
prettyprinter_1_6_0 = dontCheck super.prettyprinter_1_6_0;

# the test suite has an overly tight restriction on doctest

This comment has been minimized.

@peti

peti Feb 7, 2020
Member

Could you please add a link here to that upstream PR or issue you filed?

@Taneb Taneb mentioned this pull request Feb 7, 2020
5 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.