Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glfw: 3.3.1 -> 3.3.2 #79336

Merged
merged 1 commit into from Feb 10, 2020
Merged

glfw: 3.3.1 -> 3.3.2 #79336

merged 1 commit into from Feb 10, 2020

Conversation

@mmilata
Copy link
Member

@mmilata mmilata commented Feb 6, 2020

Motivation for this change

Fixes some bugs: https://github.com/glfw/glfw/releases/tag/3.3.2 ... notably fixes some crashes with tiling window managers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @MarcWeber @Twey @lodi

@mmilata
Copy link
Member Author

@mmilata mmilata commented Feb 6, 2020

nixpkgs-review has 1 failure unrelated to glfw:

builder for '/nix/store/spsvfq6079d98sfsk83pdv4my72fidy5-arrayfire-3.6.4.drv' failed with exit code 2; last 10 log lines:
    138 | #error -- unsupported GNU version! gcc versions later than 8 are not supported!
        |  ^~~~~
  CMake Error at cuda_compile_24_generated_thrust_sort_by_key_impl_uchar_1.cu.o.Release.cmake:220 (message):
    Error generating
    /build/arrayfire-full-3.6.4/build/src/backend/cuda/CMakeFiles/cuda_compile_24.dir/kernel/thrust_sort_by_key/./cuda_compile_24_generated_thrust_sort_by_key_impl_uchar_1.cu.o


  make[2]: *** [src/backend/cuda/CMakeFiles/cuda_thrust_sort_by_key.dir/build.make:198: src/backend/cuda/CMakeFiles/cuda_compile_24.dir/kernel/thrust_sort_by_key/cuda_compile_24_generated_thrust_sort_by_key_impl_uchar_1.cu.o] Error 1
  make[1]: *** [CMakeFiles/Makefile2:680: src/backend/cuda/CMakeFiles/cuda_thrust_sort_by_key.dir/all] Error 2
  make: *** [Makefile:152: all] Error 2
cannot build derivation '/nix/store/z1ww5r1fnlfvcgs1h0cgqhnfy4hrd874-forge-1.0.4.drv': 1 dependencies couldn't be built

Result of nixpkgs-review pr 79336 1

1 package failed to build:
  • forge (glfw3)
11 package built:
  • ccextractor (glfw3)
  • embree2 (glfw3)
  • glfw (glfw3)
  • glslviewer (glfw3)
  • goxel (glfw3)
  • idrisPackages.glfw (glfw3)
  • io (glfw3)
  • luxcorerender (glfw3)
  • tev (glfw3)
  • vcv-rack (glfw3)
  • vlang (glfw3)
@FRidh FRidh merged commit ebb3d1a into NixOS:master Feb 10, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
glfw on aarch64-linux Success
Details
glfw on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.