Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgp: init at 1.7.0.29 #79343

Merged
merged 2 commits into from Apr 2, 2020
Merged

rgp: init at 1.7.0.29 #79343

merged 2 commits into from Apr 2, 2020

Conversation

@Flakebi
Copy link
Member

@Flakebi Flakebi commented Feb 6, 2020

Motivation for this change

Add a package for the Radeon GPU Profiler, a useful tool to profile graphics applications on AMD GPUs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/development/tools/rgp/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rgp/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rgp/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rgp/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rgp/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rgp/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/rgp/default.nix Show resolved Hide resolved
@Flakebi Flakebi force-pushed the Flakebi:rgp branch from e2b04ee to f15d3ed Apr 1, 2020
@Flakebi
Copy link
Member Author

@Flakebi Flakebi commented Apr 1, 2020

Thanks for taking a look @timokau and pointing me to the documentation, it should be better now.

Copy link
Member

@timokau timokau left a comment

Looks almost perfect to me now. One more fix is needed, then this should be good to go.

pkgs/development/tools/rgp/default.nix Outdated Show resolved Hide resolved
@Flakebi Flakebi force-pushed the Flakebi:rgp branch from f15d3ed to dc4390f Apr 2, 2020
@ofborg ofborg bot added the 10.rebuild-linux: 1 label Apr 2, 2020
@Flakebi Flakebi force-pushed the Flakebi:rgp branch from dc4390f to 92ad357 Apr 2, 2020
@timokau
timokau approved these changes Apr 2, 2020
Copy link
Member

@timokau timokau left a comment

Looks good to me now. I'll give @Mic92 opportunity to disagree, since he had some comments as well. If nobody merged this by tomorrow, please ping me again.

, qtbase
, zlib
}:
with lib;

This comment has been minimized.

@timokau

timokau Apr 2, 2020
Member

I just now noticed that this with isn't necessary at all. Given the previously linked IRC discussion, it should probably be removed. I don't think its important enough to hold off merge even longer though.

@Mic92
Mic92 approved these changes Apr 2, 2020
Copy link
Contributor

@Mic92 Mic92 left a comment

Looks good to me!

@Mic92 Mic92 merged commit d343d70 into NixOS:master Apr 2, 2020
16 checks passed
16 checks passed
rgp, rgp.passthru.tests on aarch64-linux No attempt
Details
rgp, rgp.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e275ae1"; rev="e275ae1d93986f9f6e20afc2a6f62e162a7ab2c1"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e275ae1"; rev="e275ae1d93986f9f6e20afc2a6f62e162a7ab2c1"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e275ae1"; rev="e275ae1d93986f9f6e20afc2a6f62e162a7ab2c1"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e275ae1"; rev="e275ae1d93986f9f6e20afc2a6f62e162a7ab2c1"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e275ae1"; rev="e275ae1d93986f9f6e20afc2a6f62e162a7ab2c1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e275ae1"; rev="e275ae1d93986f9f6e20afc2a6f62e162a7ab2c1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e275ae1"; rev="e275ae1d93986f9f6e20afc2a6f62e162a7ab2c1"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Flakebi
Copy link
Member Author

@Flakebi Flakebi commented Apr 2, 2020

Thanks!

@Flakebi Flakebi deleted the Flakebi:rgp branch Apr 2, 2020
Tomahna added a commit to Tomahna/nixpkgs that referenced this pull request Apr 6, 2020
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.