Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sam-cli: 0.40.0 -> 0.41.0 #79351

Merged
merged 4 commits into from Feb 15, 2020
Merged

aws-sam-cli: 0.40.0 -> 0.41.0 #79351

merged 4 commits into from Feb 15, 2020

Conversation

@lo1tuma
Copy link
Member

@lo1tuma lo1tuma commented Feb 6, 2020

Motivation for this change

Release Notes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lo1tuma lo1tuma requested review from FRidh and jonringer as code owners Feb 6, 2020
@ofborg ofborg bot added the 6.topic: python label Feb 6, 2020
@ofborg ofborg bot requested a review from dhl Feb 6, 2020
@FRidh FRidh changed the title Aws sam cli 0.41.0 aws-sam-cli: 0.40.0 -> 0.41.0 Feb 6, 2020
@dhl
Copy link
Contributor

@dhl dhl commented Feb 11, 2020

@GrahamcOfBorg build -A aws-sam-cli

@dhl
dhl approved these changes Feb 11, 2020
@dhl
Copy link
Contributor

@dhl dhl commented Feb 11, 2020

Hi @lo1tuma! Thanks for keeping aws-sam-cli up-to-date.

Would you take to take over maintainership of this package? I no longer actively use aws-sam-cli and have been struggling to keep this package up to date.

@lo1tuma
Copy link
Member Author

@lo1tuma lo1tuma commented Feb 11, 2020

Hi @dhl,

I’m would be happy to maintain aws-sam-cli. I’ve pushed a new commit to change the maintainers accordingly. PTAL.

@ofborg ofborg bot requested a review from dhl Feb 11, 2020
@dhl
dhl approved these changes Feb 12, 2020
@dhl
Copy link
Contributor

@dhl dhl commented Feb 12, 2020

Hey @lo1tuma, LGTM! Thanks for your work on aws-sam-cli and agreed to take over maintainership 🙇‍♂️

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 13, 2020

Sorry, with all the stuff going on with the 20.03 release, it's hard to get around to reviewing this (had to rebuild 1000+ packages earlier today to review this)

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 13, 2020

can you rebase on top of the current master, apparently a package being disabled causes nix-review to fail.

lo1tuma added 4 commits Feb 6, 2020
@lo1tuma lo1tuma force-pushed the lo1tuma:aws-sam-cli-0.41.0 branch from c37276e to d5640e2 Feb 13, 2020
@lo1tuma
Copy link
Member Author

@lo1tuma lo1tuma commented Feb 13, 2020

Sorry, with all the stuff going on with the 20.03 release, it's hard to get around to reviewing this

No worries, there is no urgency. Thank you for all the work you are doing 🙂.

can you rebase on top of the current master

Done.

@ofborg ofborg bot requested a review from dhl Feb 13, 2020
@jonringer jonringer mentioned this pull request Feb 14, 2020
5 of 10 tasks complete
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

failures are broken on master

[5 built (35 failed), 0.0 MiB DL]
error: build of '/nix/store/gp0mrj76ynzlmcl0fjsn7ayqr0wfpxzq-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/79351
5 package marked as broken and skipped:
python37Packages.blaze python37Packages.odo python38Packages.blaze python38Packages.nipype python38Packages.odo

40 package failed to build:
python27Packages.cnvkit python37Packages.acoustics python37Packages.aplpy python37Packages.arviz python37Packages.cirq python37Packages.cnvkit python37Packages.cufflinks python37Packages.dask-jobqueue python37Packages.datashader python37Packages.google_cloud_bigquery python37Packages.ibis-framework python37Packages.imbalanced-learn python37Packages.intake python37Packages.optuna python37Packages.pymc3 python37Packages.rl-coach python37Packages.rpy2 python37Packages.streamz python37Packages.sunpy python37Packages.trackpy python38Packages.acoustics python38Packages.apache-airflow python38Packages.aplpy python38Packages.arviz python38Packages.cirq python38Packages.cnvkit python38Packages.cufflinks python38Packages.dask-jobqueue python38Packages.datashader python38Packages.google_cloud_bigquery python38Packages.ibis-framework python38Packages.imbalanced-learn python38Packages.intake python38Packages.optuna python38Packages.pymc3 python38Packages.rl-coach python38Packages.rpy2 python38Packages.streamz python38Packages.trackpy tebreak

187 package built:
apache-airflow aws-sam-cli buildbot buildbot-full buildbot-ui csvs-to-sqlite paperwork python27Packages.Quandl python27Packages.apptools python27Packages.awkward python27Packages.aws-lambda-builders python27Packages.aws-sam-translator python27Packages.bkcharts python27Packages.celery python27Packages.cfn-lint python27Packages.colorcet python27Packages.cufflinks python27Packages.drms python27Packages.envisage python27Packages.flammkuchen python27Packages.flower python27Packages.geopandas python27Packages.holoviews python27Packages.hvplot python27Packages.imbalanced-learn python27Packages.mapsplotlib python27Packages.mayavi python27Packages.moto python27Packages.nbsmoke python27Packages.pandas python27Packages.pyarrow python27Packages.pytrends python27Packages.runway-python python27Packages.statsmodels python27Packages.trackpy python27Packages.uproot python27Packages.uproot-methods python27Packages.vega python27Packages.vega_datasets python27Packages.vidstab python37Packages.Quandl python37Packages.altair python37Packages.atomman python37Packages.awkward python37Packages.aws-lambda-builders python37Packages.aws-sam-translator python37Packages.bkcharts python37Packages.caffe python37Packages.celery python37Packages.cfn-lint python37Packages.colorcet python37Packages.dask python37Packages.dask-glm python37Packages.dask-image python37Packages.dask-ml python37Packages.dask-mpi python37Packages.dask-xgboost python37Packages.dftfit python37Packages.distributed python37Packages.django-raster python37Packages.djmail python37Packages.drms python37Packages.fastparquet python37Packages.flammkuchen python37Packages.flower python37Packages.geopandas python37Packages.glymur python37Packages.google_cloud_monitoring python37Packages.holoviews python37Packages.hvplot python37Packages.image-match python37Packages.imgaug python37Packages.lammps-cython python37Packages.mesa python37Packages.moto python37Packages.nbsmoke python37Packages.nilearn python37Packages.nipype python37Packages.osmnx python37Packages.pandas python37Packages.partd python37Packages.phik python37Packages.pims python37Packages.pvlib python37Packages.pyarrow python37Packages.pybids python37Packages.pyfftw python37Packages.pymatgen python37Packages.pymatgen-lammps python37Packages.pytrends python37Packages.runway-python python37Packages.scikit-bio python37Packages.scikitimage python37Packages.seaborn python37Packages.sentry-sdk python37Packages.statsmodels python37Packages.stumpy python37Packages.stytra python37Packages.sumo python37Packages.tablib python37Packages.uproot python37Packages.uproot-methods python37Packages.vega python37Packages.vega_datasets python37Packages.vidstab python37Packages.wrf-python python37Packages.xarray python37Packages.xgboost python38Packages.Quandl python38Packages.altair python38Packages.atomman python38Packages.awkward python38Packages.aws-lambda-builders python38Packages.aws-sam-translator python38Packages.bkcharts python38Packages.buildbot python38Packages.buildbot-full python38Packages.buildbot-ui python38Packages.caffe python38Packages.celery python38Packages.cfn-lint python38Packages.colorcet python38Packages.csvs-to-sqlite python38Packages.dask python38Packages.dask-glm python38Packages.dask-image python38Packages.dask-ml python38Packages.dask-mpi python38Packages.dask-xgboost python38Packages.dftfit python38Packages.distributed python38Packages.django-raster python38Packages.djmail python38Packages.drms python38Packages.fastparquet python38Packages.flammkuchen python38Packages.flower python38Packages.geopandas python38Packages.glymur python38Packages.google_cloud_monitoring python38Packages.holoviews python38Packages.hvplot python38Packages.image-match python38Packages.imgaug python38Packages.lammps-cython python38Packages.moto python38Packages.nbsmoke python38Packages.nilearn python38Packages.osmnx python38Packages.pandas python38Packages.partd python38Packages.phik python38Packages.pims python38Packages.pvlib python38Packages.pyarrow python38Packages.pybids python38Packages.pyfftw python38Packages.pymatgen python38Packages.pymatgen-lammps python38Packages.pytrends python38Packages.runway-python python38Packages.scikit-bio python38Packages.scikitimage python38Packages.seaborn python38Packages.statsmodels python38Packages.stytra python38Packages.sumo python38Packages.tablib python38Packages.uproot python38Packages.uproot-methods python38Packages.vega python38Packages.vega_datasets python38Packages.vidstab python38Packages.wrf-python python38Packages.xarray python38Packages.xgboost sourcehut.buildsrht sourcehut.dispatchsrht sourcehut.gitsrht sourcehut.hgsrht sourcehut.listssrht sourcehut.mansrht sourcehut.metasrht sourcehut.pastesrht sourcehut.todosrht streamlit visidata
@jonringer jonringer merged commit 8b6e471 into NixOS:master Feb 15, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
aws-sam-cli on aarch64-linux Success
Details
aws-sam-cli on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@lo1tuma lo1tuma deleted the lo1tuma:aws-sam-cli-0.41.0 branch Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.