Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtail: 3.0.0-rc4 -> 3.0.0-rc34 #79356

Merged
merged 1 commit into from Mar 18, 2020
Merged

mtail: 3.0.0-rc4 -> 3.0.0-rc34 #79356

merged 1 commit into from Mar 18, 2020

Conversation

@bbigras
Copy link
Contributor

@bbigras bbigras commented Feb 6, 2020

Motivation for this change

3.0.0-rc4 is over 2 years old. no release yet...

Things done

This update has a tiny lie.

I saw from the manual that go2nix is normally used for goDeps but on the go2nix repo it says to use vgo2nix when there a go.mod file present.

The thing is that vgo2nix fails with 3.0.0-rc34 but not with master, so I generated the file with master. master only has tiny changes. It's mostly a deps update. (check google/mtail@v3.0.0-rc34...0150dad)

If it's not OK I could another way. I also wanted to switch the package to buildGoModule but I got some problem: #79355

Also, is gotools needed?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/z0dk0mhfsni2lpaqpw2pnjgs0y9vzsyl-mtail-3.0.0-rc4-bin 40.4M
/nix/store/1m6f7yfly52fpa4rwwsvwqkrxmfd7h8a-mtail-3.0.0-rc35 45.5M

@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Feb 6, 2020

Another tiny thing is that mtail --version will print:
mtail version 3.0.0-rc34 git revision invalid:-use-make-to-build go version go1.13.7 go arch amd64 go os linux

since I only set Version. We could also set Branch and Revision.

https://github.com/google/mtail/blob/7b4270cb6e8b6ed1f2febe48e370cb68d38681f9/cmd/mtail/main.go#L77-L80

@ofborg ofborg bot requested a review from ehmry Feb 6, 2020
@bbigras bbigras force-pushed the bbigras:mtail branch from 9a596e2 to e19d133 Feb 6, 2020
@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Feb 6, 2020

It seems my problem with buildGoModule doesn't happen anymore. I made the change to use buildGoModule now.

@bbigras bbigras force-pushed the bbigras:mtail branch from e19d133 to c6ffb38 Feb 6, 2020
@ofborg ofborg bot requested a review from kalbasit Feb 6, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Feb 8, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/115

@bbigras bbigras force-pushed the bbigras:mtail branch from c6ffb38 to f12f34b Mar 3, 2020
@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Mar 3, 2020

done, thanks @doronbehar

@bbigras bbigras force-pushed the bbigras:mtail branch from f12f34b to 0ac00f0 Mar 7, 2020
@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Mar 7, 2020

I done all the changes and updated to rc35. thanks

Copy link
Contributor

@doronbehar doronbehar left a comment

Great, tested basic --help and no comments left :).

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Mar 13, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/114

@nh2 nh2 merged commit 4366606 into NixOS:master Mar 18, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mtail on aarch64-linux Success
Details
mtail on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.