Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpcurl: 1.0.0 -> 1.4.0 #79361

Merged
merged 1 commit into from Feb 7, 2020
Merged

grpcurl: 1.0.0 -> 1.4.0 #79361

merged 1 commit into from Feb 7, 2020

Conversation

@bbigras
Copy link
Contributor

@bbigras bbigras commented Feb 6, 2020

Motivation for this change

1.0.0 is over a year old.

Things done

I didn't build on darwin. I have no idea if the 2 distinct deps files are still required.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/7nk0jmh4s64vr333v6bgibh6g449wv24-grpcurl-1.0.0-bin 61.1M
/nix/store/s7s1rx0vqvb76makhr39fcajddznb2sr-grpcurl-1.4.0-bin 63.3M

@knl
Copy link
Contributor

@knl knl commented Feb 6, 2020

@GrahamcOfBorg build grpcurl

@knl
Copy link
Contributor

@knl knl commented Feb 7, 2020

I've built this on my macOS and can confirm it builds and works there.

@knl
knl approved these changes Feb 7, 2020
Copy link
Contributor

@knl knl left a comment

Looks good, thanks. I tested it on darwin as well.

@basvandijk basvandijk merged commit a7ae4cb into NixOS:master Feb 7, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
grpcurl on aarch64-linux Success
Details
grpcurl on x86_64-linux Success
Details
@bbigras bbigras deleted the bbigras:grpcurl branch Feb 7, 2020
@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Feb 7, 2020

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.