Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jirafeau: init at 4.1.1 + module #79363

Merged
merged 2 commits into from Feb 18, 2020
Merged

jirafeau: init at 4.1.1 + module #79363

merged 2 commits into from Feb 18, 2020

Conversation

@davidtwco
Copy link
Member

@davidtwco davidtwco commented Feb 6, 2020

Motivation for this change

Adds a package for Jirafeau and a module for configuring and running Jirafeau.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
davidtwco added 2 commits Feb 6, 2020
Signed-off-by: David Wood <david.wood@codeplay.com>
Signed-off-by: David Wood <david.wood@codeplay.com>
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM (but I'm not great at nixos modules)

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79363
1 package blacklisted:
tests.nixos-functions.nixos-test

1 package built:
jirafeau

however, running the tests i get:

machine: connected to guest root shell
machine: (connecting took 0.00 seconds)
(0.00 seconds)
error: [Errno 32] Broken pipe
cleaning up
killing machine (pid 9)
(0.00 seconds)
builder for '/nix/store/170yvxcmcv3dvwdx98a8hsqk3k3y9mhc-vm-test-run-jirafeau.drv' failed with exit code 1
error: build of '/nix/store/170yvxcmcv3dvwdx98a8hsqk3k3y9mhc-vm-test-run-jirafeau.drv' failed
@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 18, 2020

@GrahamcOfBorg test jirafeau

@davidtwco
Copy link
Member Author

@davidtwco davidtwco commented Feb 18, 2020

It appears that the test passes for ofborg and it still passes for me locally.

@jonringer jonringer merged commit 60a3d9d into NixOS:master Feb 18, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
jirafeau on aarch64-linux Success
Details
jirafeau on x86_64-linux Success
Details
tests.jirafeau on aarch64-linux Success
Details
tests.jirafeau on x86_64-linux Success
Details
@davidtwco davidtwco deleted the davidtwco:jirafeau-init branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.