Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libuv: 1.32.0 -> 1.34.2 (cherry-pick on release-19.09) #79373

Closed

Conversation

@basvandijk
Copy link
Member

@basvandijk basvandijk commented Feb 6, 2020

Motivation for this change

This should fix some flaky tests on darwin: #79372

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
r-ryantm and others added 4 commits Nov 2, 2019
(cherry picked from commit 5728d7d)
(cherry picked from commit ef135db)
(cherry picked from commit 6a6ba8f)
(cherry picked from commit 389177c)
@basvandijk
Copy link
Member Author

@basvandijk basvandijk commented Feb 6, 2020

@GrahamcOfBorg build libuv

@basvandijk
Copy link
Member Author

@basvandijk basvandijk commented Feb 6, 2020

I will target this for staging-19.09.

@basvandijk
Copy link
Member Author

@basvandijk basvandijk commented Feb 6, 2020

Closing in favor of #79383.

@basvandijk basvandijk closed this Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.