Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metals: 0.7.6 -> 0.8.1 #79376

Merged
merged 1 commit into from Mar 12, 2020
Merged

metals: 0.7.6 -> 0.8.1 #79376

merged 1 commit into from Mar 12, 2020

Conversation

@liff
Copy link
Contributor

@liff liff commented Feb 6, 2020

Motivation for this change

Metals 0.8.0 (Cobalt) release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Feb 7, 2020

Thanks @liff!

Metals 0.8 supports Java 11, but it doesn't require it, does it? I'm not very well versed in the conventions for this sort of thing with nixpkgs, but I wonder if it would make sense to keep the derivation the way that it was and let people choose which jdk they want to use. You could potentially change all-packages.nix to explicitly pass jdk11 in for both arguments, but it looks like currently it is using jdk8 as the default for most builds - I'm not sure whether there's a particular reason for that.

I'm hoping a more experienced Nix maintainer can weigh in on this.

@liff liff force-pushed the liff:metals/v0.8.0 branch from 3167732 to cb1cae3 Feb 8, 2020
@liff
Copy link
Contributor Author

@liff liff commented Feb 8, 2020

I’ve reverted the JDK version change.

@ceedubs
ceedubs approved these changes Feb 8, 2020
Copy link
Contributor

@ceedubs ceedubs left a comment

LGTM!

@Tomahna
Copy link
Contributor

@Tomahna Tomahna commented Feb 21, 2020

LGTM too

@liff liff force-pushed the liff:metals/v0.8.0 branch from cb1cae3 to cc42fe4 Mar 1, 2020
@liff liff changed the title metals: 0.7.6 -> 0.8.0 metals: 0.7.6 -> 0.8.1 Mar 1, 2020
@ofborg ofborg bot requested a review from ceedubs Mar 1, 2020
@ceedubs
ceedubs approved these changes Mar 1, 2020
@alyssais alyssais merged commit c924fe8 into NixOS:master Mar 12, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
metals on aarch64-linux Success
Details
metals on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.