Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make myself a maintainer #79455

Merged
merged 2 commits into from Feb 8, 2020
Merged

Make myself a maintainer #79455

merged 2 commits into from Feb 8, 2020

Conversation

@Atemu
Copy link
Member

@Atemu Atemu commented Feb 7, 2020

Motivation for this change

#79085 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Atemu Atemu changed the title Maintainers atemu Make myself a maintainer Feb 7, 2020
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 7, 2020

nit 39519d2, can the message not be uppercase Maintainers but just lower case?

@Atemu
Copy link
Member Author

@Atemu Atemu commented Feb 7, 2020

Sure, is that the general code style for commit messages in nixpkgs?

Atemu added 2 commits Feb 7, 2020
Glad to be contributing to such a great project :)
@Atemu Atemu force-pushed the Atemu:maintainers-atemu branch from f745183 to 64ce6b2 Feb 7, 2020
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 7, 2020

Sure, is that the general code style for commit messages in nixpkgs?

Usually it's an attribute path or a file path https://github.com/NixOS/nixpkgs/commits/master/maintainers.
In this case the directory is not uppercase, and the attribute in stdenv.lib is maintainers.

@FRidh
Copy link
Member

@FRidh FRidh commented Feb 8, 2020

cc @waynr

@worldofpeace worldofpeace merged commit 26d618b into NixOS:master Feb 8, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
dnscrypt-proxy2 on aarch64-linux Success
Details
dnscrypt-proxy2 on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Atemu Atemu deleted the Atemu:maintainers-atemu branch Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.