Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Motivation for this change
Since v0.19.0 aws-sam-cli sends telemetry data to AWS. To protect the users'
Output edited to improve readability.
Note that they assign unique values to:
Hey @stefano-m, sorry for the delay in getting back to you.
Personally, I am okay with disabling telemetry by default (and thanks for being privacy-conscious!). I gave this a bit more thought and felt that by generating a wrapper around
Can we generate the wrapper conditionally, so user's can actually override the default and opt in?
@dhl I can see your point, although I fail to understand why someone wanted to use telemetry (
Note that for example
(Disclosure: I somewhat contributed to those setting with #74516)
If you still prefer to have the option to enable telemetry, I would propose instead that we generate the wrapper with telemetry disabled by default and add a conditional parameter to the derivation to explicitly enable telemetry.
Would you be OK with that?
If someone really wants to opt into telemetry, they can do so by setting `enableTelemetry` to `true` (the default is `false`), in which case the wrapper that sets `SAM_CLI_TELEMETRY` to `0` will not be created. Note that this actually allows a user to optionally disable telemetry from the command line or the (poorly documented) configuration in `~/.aws-sam/metadata.json`. The downside is telemetry will be enabled at least on the first run, causing a unique installation ID to be saved in the configuration file.