Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] go_1_13: 1.13.1 -> 1.13.7, go_1_12: 1.12.9 -> 1.12.16 (backport) #79513

Merged
merged 11 commits into from Feb 9, 2020

Conversation

@Frostman
Copy link
Member

@Frostman Frostman commented Feb 8, 2020

Motivation for this change

Backport latest patch versions for go in 19.09 branch as there are tons of CVE fixed in them. I'm not sure what should be the process, but, IMO it's quite important from security point of view.

@kalbasit probably, you can advise, thank you!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Frostman
Copy link
Member Author

@Frostman Frostman commented Feb 8, 2020

nixpkgs-review pr 79513 succeded with 666 packages built

@kalbasit
Copy link
Member

@kalbasit kalbasit commented Feb 8, 2020

Please cherry-pick all backported commits with -x.

See https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes

d-goldin and others added 11 commits Oct 1, 2019
GO 1.12.10 has been released 5 days ago, so
bumping it in the hope that it also fixes some
flakey GC tests.

Also see #69359

(cherry picked from commit aa46781)
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/go/versions

(cherry picked from commit c307ed8)
(cherry picked from commit eb87a73)
Prepend the nix path to the zoneinfo.zip file and keep the original alternatives
to allow go programs built using nix to run on non nix servers.

see #54603

(cherry picked from commit 5a0be78)
(cherry picked from commit 85a369d)
The test is known to be flaky in some environments, and I'm seeing it
consistently in an armv7l-linux vm.

(cherry picked from commit ffd68f2)
(cherry picked from commit 116b5c5)
(cherry picked from commit 3e30f56)
(cherry picked from commit 60bb60b)
(cherry picked from commit 1092ba6)
@Frostman Frostman force-pushed the Frostman:stable-go-bump branch from e0425ef to 6a9e8e6 Feb 8, 2020
@Frostman
Copy link
Member Author

@Frostman Frostman commented Feb 8, 2020

Executed nixpkgs-review pr 79513 one more time just in case - works fine. With that PR go compiler in 19.09 is in sync with current unstable.

@kalbasit
Copy link
Member

@kalbasit kalbasit commented Feb 9, 2020

@GrahamcOfBorg build pet jx kubectl prow

@kalbasit kalbasit merged commit 018a6fd into NixOS:release-19.09 Feb 9, 2020
18 checks passed
18 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
go, go_1_12, go_1_13 on aarch64-linux Success
Details
go, go_1_12, go_1_13 on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
jx, kubectl, pet, prow on aarch64-linux Success
Details
jx, kubectl, pet, prow on x86_64-darwin Success
Details
jx, kubectl, pet, prow on x86_64-linux Success
Details
@Frostman Frostman deleted the Frostman:stable-go-bump branch Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.