Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stylish haskell by using HsYAML 0.2.1.0 #79528

Merged
merged 2 commits into from Feb 8, 2020

Conversation

@clkamp
Copy link
Contributor

@clkamp clkamp commented Feb 8, 2020

Fixes #79130

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Christian Lütke-Stetzkamp added 2 commits Feb 8, 2020
@cdepillabout cdepillabout merged commit 89ae888 into NixOS:haskell-updates Feb 8, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Feb 8, 2020

Looks good, thanks for fixing this up!

@clkamp clkamp deleted the clkamp:fix-stylish-haskell branch Feb 8, 2020
@rpearce
Copy link
Contributor

@rpearce rpearce commented Feb 11, 2020

Thank you for this

@turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Feb 12, 2020

Oh great that this is fixed and merged, thanks!

@rpearce
Copy link
Contributor

@rpearce rpearce commented Feb 21, 2020

Looks like this was merged 13 days ago...is it out in the world yet? I'm not picking it up in the unstable channel, but I'm also not the most experienced nixer

@turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Feb 21, 2020

@rpearce
Copy link
Contributor

@rpearce rpearce commented Feb 21, 2020

benkolera added a commit to benkolera/nix that referenced this pull request Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.