Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qttools: Add qtdeclarative to buildInputs #79558

Merged
merged 1 commit into from Feb 11, 2020

Conversation

@Thra11
Copy link
Contributor

@Thra11 Thra11 commented Feb 8, 2020

qtdeclarative is an optional dependency for some parts of qttools:
without it, the lupdate binary is not able to process qml files for
translatable strings.

Motivation for this change

I tried to run lupdate on some qml files and it did nothing and output the following warning:

warning: Some files have been ignored due to missing qml/javascript support
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Thra11
Copy link
Contributor Author

@Thra11 Thra11 commented Feb 8, 2020

Ouch! That's a lot of rebuilds. To be expected though. Might be worth checking whether there are any other missing dependencies so we can sneak them all in in one go.

@veprbl
Copy link
Member

@veprbl veprbl commented Feb 9, 2020

Ouch! That's a lot of rebuilds.

Eight hundred for x86_64-linux. I would consider targeting this to the staging branch instead of master.

qtdeclarative is an optional dependency for some parts of qttools:
without it, the lupdate binary is not able to process qml files for
translatable strings.
@FRidh
Copy link
Member

@FRidh FRidh commented Feb 11, 2020

Please target staging branch.

@FRidh FRidh added this to Needs review in Staging Feb 11, 2020
@ttuegel ttuegel force-pushed the Thra11:add-qtdeclarative-qttools branch from f1d2338 to 704b49d Feb 11, 2020
@ttuegel ttuegel changed the base branch from master to staging Feb 11, 2020
Copy link
Member

@ttuegel ttuegel left a comment

Looks good to me. I tested on staging myself.

Staging automation moved this from Needs review to Ready Feb 11, 2020
@ttuegel ttuegel merged commit f9ddb17 into NixOS:staging Feb 11, 2020
12 of 15 checks passed
12 of 15 checks passed
drumkv1, gitfs, gnutls, libgit2, libmtp, lz4, ninja on aarch64-linux
Details
drumkv1, gitfs, gnutls, libgit2, libmtp, lz4, ninja on x86_64-linux
Details
grahamcofborg-eval Checking original out paths
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Staging automation moved this from Ready to Done Feb 11, 2020
@Thra11 Thra11 deleted the Thra11:add-qtdeclarative-qttools branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.