Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calibre: add missing dependency, fixes #78642 #79608

Merged
merged 2 commits into from Feb 10, 2020
Merged

Conversation

@chamatht
Copy link
Contributor

@chamatht chamatht commented Feb 9, 2020

Fixes #78642
This commit adds pyqtwebengine.

Motivation for this change

Without pyqtwebengine, when you try to view an ebook, you get the following error

Traceback (most recent call last):
  File "/nix/store/1zqhszwa961qf3nciz5wv854sfff18ph-calibre-4.8.0/bin/.calibre-parallel-wrapped", line 20, in <module>
    sys.exit(main())
  File "/nix/store/1zqhszwa961qf3nciz5wv854sfff18ph-calibre-4.8.0/lib/calibre/calibre/utils/ipc/worker.py", line 209, in main
    result = func(*args, **kwargs)
  File "/nix/store/1zqhszwa961qf3nciz5wv854sfff18ph-calibre-4.8.0/lib/calibre/calibre/gui_launch.py", line 80, in ebook_viewer
    from calibre.gui2.viewer.main import main
  File "/nix/store/1zqhszwa961qf3nciz5wv854sfff18ph-calibre-4.8.0/lib/calibre/calibre/gui2/viewer/main.py", line 12, in <module>
    from PyQt5.QtWebEngineCore import QWebEngineUrlScheme
ImportError: No module named QtWebEngineCore

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

This commit adds pyqtwebengine.
Without pyqtwebengine, viewing ebooks yeild the error
 "ImportError: No module named QtWebEngineCore".
@chamatht chamatht requested review from peterhoeg and FRidh Feb 9, 2020
@FRidh FRidh changed the title calibre: add missing dependency calibre: add missing dependency, fixes #78642 Feb 9, 2020
@FRidh
Copy link
Member

@FRidh FRidh commented Feb 9, 2020

Fixes #78642

@chamatht chamatht removed the request for review from peterhoeg Feb 9, 2020
@ofborg ofborg bot requested review from pSub, domenkozar and AndersonTorres Feb 9, 2020
@pSub
pSub approved these changes Feb 9, 2020
@FRidh
Copy link
Member

@FRidh FRidh commented Feb 9, 2020

As written in #78642, we should not need webkit anymore so that change needs to be made.

@chamatht
Copy link
Contributor Author

@chamatht chamatht commented Feb 9, 2020

@FRidh made the change

@ofborg ofborg bot requested a review from pSub Feb 9, 2020
@veprbl veprbl mentioned this pull request Feb 10, 2020
19 of 68 tasks complete
@veprbl
veprbl approved these changes Feb 10, 2020
Copy link
Member

@veprbl veprbl left a comment

Works

@veprbl veprbl merged commit 16fe603 into NixOS:master Feb 10, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
calibre on aarch64-linux Success
Details
calibre on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@chamatht chamatht deleted the chamatht:calibre branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.