Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade brave 1.1.23 to 1.3.113 #79634

Closed
wants to merge 2 commits into from

Conversation

@JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Feb 9, 2020

Motivation for this change

I wanted the latest version of brave and thought that the community would benifit as well

Things done

Changed the version to the latest stable version available today, changed the checksum to
match the checksum of the new deb.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested a review from uskudnik Feb 9, 2020
@JeffLabonte JeffLabonte requested review from zowoq and worldofpeace Feb 12, 2020
@JeffLabonte JeffLabonte force-pushed the JeffLabonte:brave_1.1.23_to_1.3.113 branch from e2f413e to 5f3c0f9 Feb 12, 2020
@JeffLabonte
Copy link
Contributor Author

@JeffLabonte JeffLabonte commented Feb 12, 2020

I will update my PR, remove the things that shouldn't be there and add myself as a maintainer of this package!

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 12, 2020

@JeffLabonte Cool, ping me on the PR when you open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.