Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python27Packages.nwdiag: 1.0.4 -> 2.0.0 #79654

Merged
merged 2 commits into from Feb 9, 2020
Merged

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 9, 2020

Motivation for this change

noticed this:

  File "/nix/store/lwrfjajvzwmxqdgz5h5y0sjd9g08kk80-python3.8-blockdiag-1.5.3/lib/python3.8/site-packages/blockdiag/imagedraw/__init__.py", line 16, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

not sure how to add commits to other PRs

closes #79644

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/79654
4 package built:
asciidoc-full-with-plugins nwdiag python27Packages.nwdiag python38Packages.nwdiag
r-ryantm and others added 2 commits Feb 9, 2020
@jonringer jonringer requested a review from FRidh as a code owner Feb 9, 2020
@jonringer jonringer requested a review from bjornfor Feb 9, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Feb 9, 2020

@GrahamcOfBorg build asciidoc-full-with-plugins nwdiag python27Packages.nwdiag python38Packages.nwdiag

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Feb 9, 2020

passes on darwin

@jonringer jonringer merged commit c10ecb9 into NixOS:master Feb 9, 2020
2 of 3 checks passed
2 of 3 checks passed
asciidoc-full-with-plugins, nwdiag, python27Packages.nwdiag, python38Packages.nwdiag on aarch64-linux
Details
asciidoc-full-with-plugins, nwdiag, python27Packages.nwdiag, python38Packages.nwdiag on x86_64-darwin Success
Details
asciidoc-full-with-plugins, nwdiag, python27Packages.nwdiag, python38Packages.nwdiag on x86_64-linux Success
Details
@jonringer jonringer deleted the jonringer:bump-nwdiag branch Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.