Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-combined: readd keymap tests #79656

Merged
merged 1 commit into from Feb 10, 2020

Conversation

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 9, 2020

These are building just fine for a while now 0.
I restricted them from bulding on aarch64-linux because
there's still issues there.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace worldofpeace added this to the 20.03 milestone Feb 9, 2020
@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Feb 9, 2020

Looking at https://hydra.nixos.org/jobset/nixos/trunk-combined#tabs-jobs (search for keymap) job, all of them are and have been passing just fine.

@worldofpeace worldofpeace changed the title release-combined: readde keymap tests release-combined: readd keymap tests Feb 9, 2020
These are building just fine for a while now [0].
I restricted them from bulding on aarch64-linux because
there's still issues there.

[0]: https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.keymap.dvorak.x86_64-linux/all
@worldofpeace worldofpeace force-pushed the worldofpeace:readd-keymap-to-tested branch from 1f53648 to bf49181 Feb 9, 2020
@worldofpeace worldofpeace requested review from vcunat and FRidh Feb 9, 2020
@worldofpeace worldofpeace merged commit 134665d into NixOS:master Feb 10, 2020
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@worldofpeace worldofpeace deleted the worldofpeace:readd-keymap-to-tested branch Feb 10, 2020
vcunat added a commit that referenced this pull request Feb 13, 2020
It's a temporary measure until we have better ways.  See #79907.
(Not a real revert, as the comment wouldn't make sense, etc.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.