Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sdk-cpp: build shared libraries #79660

Closed

Conversation

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Feb 9, 2020

Same fix as #79616

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Same fix as #79616
@marsam
marsam approved these changes Feb 10, 2020
@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Feb 10, 2020

I actually can build aws-sdk-cpp on linux fine on master.

@Frostman
Copy link
Member

@Frostman Frostman commented Feb 10, 2020

nixpkgs-review pr 79660 passed just fine.

@worldofpeace worldofpeace removed this from the 20.03 milestone Feb 10, 2020
@veprbl
veprbl approved these changes Feb 10, 2020
Copy link
Member

@veprbl veprbl left a comment

Passes nix-review on x86_64-darwin

5 package are marked as broken and were skipped:
fusionInventory nix-exec nixui packagekit packagekit-qt

2 package failed to build:
crystal2nix python38Packages.nixpkgs

34 package were build:
aws-sdk-cpp bundix cabal2nix cachix dep2nix disnix go2nix haskellPackages.cachix haskellPackages.nix-paths nix nix-bundle nix-du nix-index nix-pin nix-plugins nix-prefetch nix-prefetch-bzr nix-prefetch-cvs nix-prefetch-docker nix-prefetch-git nix-prefetch-hg nix-prefetch-scripts nix-prefetch-svn nix-serve nix-update-source nixFlakes nixUnstable nixos-generators nixpkgs-review python37Packages.nixpkgs python37Packages.pythonix python38Packages.pythonix vgo2nix vulnix
@FRidh
Copy link
Member

@FRidh FRidh commented Feb 10, 2020

On staging-next cffec21:

CMake Error at /nix/store/hl0wvz7gvh1c05zc0a7nn2c1cmk9bxpw-aws-checksums-0.1.5/lib/aws-checksums/cmake/aws-checksums-config.cmake:2 (include):
  include could not find load file:

    /nix/store/hl0wvz7gvh1c05zc0a7nn2c1cmk9bxpw-aws-checksums-0.1.5/lib/aws-checksums/cmake/shared/aws-checksums-targets.cmake
Call Stack (most recent call first):
  /nix/store/7akhja8x44zxxd3fkydxsa5m78whw2ff-cmake-3.16.3/share/cmake-3.16/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
  /nix/store/9s7a9hgpcmypqpzdinqqd51s3jpxq7ar-aws-c-event-stream-0.1.1/lib/aws-c-event-stream/cmake/aws-c-event-stream-config.cmake:3 (find_dependency)
  aws-cpp-sdk-core/CMakeLists.txt:468 (find_package)


-- Looking for include file pulse/simple.h
-- Looking for include file pulse/simple.h - not found
CMake Warning at aws-cpp-sdk-text-to-speech/CMakeLists.txt:31 (message):
  We've detected that you are building on linux, but the header files for
  pulseaudio are not available.  If you are providing your own audio
  implementation or you will not be using the text-to-speech library, this is
  fine.  However, if you are not providing your own implemenation and you
  want to use text-to-speech, you need to install the dev files for
  pulseAudio.  e.g.  apt-get install libpulse-dev or yum install
  pulseaudio-libs-devel.  Currently, no audio implementation will be built
  into this library.


-- Configuring incomplete, errors occurred!
See also "/build/source/build/CMakeFiles/CMakeOutput.log".
See also "/build/source/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/js8xfkqhhhsybaiznj21fwylgdlpj9qi-aws-sdk-cpp-1.7.90.drv' failed with exit code 1
error: build of '/nix/store/js8xfkqhhhsybaiznj21fwylgdlpj9qi-aws-sdk-cpp-1.7.90.drv' failed

The warning must be unrelated I think.

@FRidh FRidh mentioned this pull request Feb 10, 2020
0 of 10 tasks complete
@FRidh
Copy link
Member

@FRidh FRidh commented Feb 10, 2020

nevermind, master had to be merged in staging-next to receive the other aws fixes.

@FRidh FRidh closed this Feb 10, 2020
@worldofpeace worldofpeace deleted the worldofpeace:fix-build-aws-sdk-cpp branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.