Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spleen: install otf font #79671

Merged
merged 1 commit into from Feb 11, 2020
Merged

spleen: install otf font #79671

merged 1 commit into from Feb 11, 2020

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 10, 2020

Motivation for this change

Issue #75160

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested fonts are working in X11 and GTK application
  • Tested compilation of all pkgs that depend on this change using
  • Tested execution of all binary files (none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Feb 11, 2020

Looks good, files are there and are valid fonts - tested with ImageMagick's display.

results/spleen/share/
├── consolefonts
│   ├── spleen-12x24.psfu
│   ├── spleen-16x32.psfu
│   ├── spleen-32x64.psfu
│   ├── spleen-5x8.psfu
│   └── spleen-8x16.psfu
└── fonts
    └── misc
        ├── fonts.alias
        ├── fonts.dir
        ├── spleen-12x24.bdf
        ├── spleen-12x24.pcf
        ├── spleen-16x32.bdf
        ├── spleen-16x32.pcf
        ├── spleen-32x64.bdf
        ├── spleen-32x64.pcf
        ├── spleen-5x8.bdf
        ├── spleen-5x8.pcf
        ├── spleen-8x16.bdf
        ├── spleen-8x16.pcf
        └── spleen.otf
@JohnAZoidberg JohnAZoidberg merged commit 9b2d529 into NixOS:master Feb 11, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
spleen on aarch64-linux Success
Details
spleen on x86_64-darwin Success
Details
spleen on x86_64-linux Success
Details
@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Feb 11, 2020

Thank you!

@rnhmjoj rnhmjoj deleted the rnhmjoj:spleen branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.