Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merriweather{,-sans}: add new fonts #79686

Merged
merged 2 commits into from Feb 24, 2020

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Feb 10, 2020

Motivation for this change

Merriweather is a popular OFL-licensed font on Google Fonts; its metrics are comparable to Georgia, making it a good freely-licensed replacement. I've also included its sister Sans face. It's already packaged in openSUSE, Alpine and the Arch User Repository.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 10, 2020

@GrahamcOfBorg build merriweather merriweather-sans

@emilazy emilazy force-pushed the emilazy:add-merriweather-fonts branch from e252424 to 7f1ab05 Feb 11, 2020
@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 11, 2020

Updated to use stdenvNoCC to cut down on extraneous rebuilds.

@GrahamcOfBorg build merriweather merriweather-sans

@yegortimoshenko yegortimoshenko merged commit 2ee99b4 into NixOS:master Feb 24, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
merriweather, merriweather-sans on aarch64-linux Success
Details
merriweather, merriweather-sans on x86_64-linux Success
Details
@emilazy emilazy deleted the emilazy:add-merriweather-fonts branch Feb 24, 2020
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Feb 24, 2020
merriweather{,-sans}: add new fonts

(cherry picked from commit 2ee99b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.