Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pysnow: init at 0.7.14 #79687

Merged
merged 2 commits into from Feb 12, 2020
Merged

pythonPackages.pysnow: init at 0.7.14 #79687

merged 2 commits into from Feb 12, 2020

Conversation

@a1mac
Copy link

@a1mac a1mac commented Feb 10, 2020

Motivation for this change

Adding pysnow into nixpkgs and adding myself as the maintainer for the package.

Note

Separate commit with the maintainer info only was denied: #79160
I have a few more packages that I would like to add given that this one is accepted

Things done

I tested builds with different versions of python on centos with nixpkgs.
I did integration testing with py37 on nixos (nix-shell).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/python-modules/pysnow/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@WorldQuantOS WorldQuantOS force-pushed the WorldQuant:wq_pysnow branch from 6c0779f to e2fc371 Feb 11, 2020
@a1mac
Copy link
Author

@a1mac a1mac commented Feb 11, 2020

Working on fixing it, please don't close. Thanks!

@WorldQuantOS WorldQuantOS force-pushed the WorldQuant:wq_pysnow branch from e2fc371 to 7641775 Feb 11, 2020
Alma Cemerlic added 2 commits Feb 10, 2020
@WorldQuantOS WorldQuantOS force-pushed the WorldQuant:wq_pysnow branch from 7641775 to 13ca17f Feb 12, 2020
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM

[12 built, 210 copied (781.5 MiB), 141.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79687
3 package built:
python27Packages.pysnow python37Packages.pysnow python38Packages.pysnow
@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 12, 2020

@GrahamcOfBorg build python27Packages.pysnow python37Packages.pysnow python38Packages.pysnow

@jonringer jonringer merged commit efc75b3 into NixOS:master Feb 12, 2020
15 of 16 checks passed
15 of 16 checks passed
python27Packages.pysnow, python37Packages.pysnow, python38Packages.pysnow on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.pysnow, python37Packages.pysnow, python38Packages.pysnow on aarch64-linux Success
Details
python27Packages.pysnow, python37Packages.pysnow, python38Packages.pysnow on x86_64-darwin Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.