Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 Packages - digi-xbee and srp #79688

Merged
merged 3 commits into from Feb 12, 2020
Merged

Conversation

@JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Feb 10, 2020

Motivation for this change

Those are packages that I use at work for some of my devices, I felt like it would be a good idea
to share with the community packages I made for myself.

Things done

Create package called digi-xbee 1.3.0 and srp 1.0.15

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jonringer jonringer left a comment

should be 3 commits

maintainers: add jefflabonte
pythonPackages.digi-xbee: init at 1.3.0
pythonPackages.srp: init at 1.0.15
pkgs/development/python-modules/digi-xbee/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/digi-xbee/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/digi-xbee/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/srp/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/srp/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/srp/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/srp/default.nix Outdated Show resolved Hide resolved
@JeffLabonte JeffLabonte force-pushed the JeffLabonte:python3_digi-xbee branch 2 times, most recently from f35cfd9 to c6fb08b Feb 11, 2020
@JeffLabonte JeffLabonte force-pushed the JeffLabonte:python3_digi-xbee branch 2 times, most recently from e478c91 to 8af9c97 Feb 11, 2020
@JeffLabonte
Copy link
Contributor Author

@JeffLabonte JeffLabonte commented Feb 11, 2020

should be 3 commits

maintainers: add jefflabonte
pythonPackages.digi-xbee: init at 1.3.0
pythonPackages.srp: init at 1.0.15

Yup, I changed my commit messages

@JeffLabonte JeffLabonte force-pushed the JeffLabonte:python3_digi-xbee branch 2 times, most recently from e478c91 to 717447c Feb 12, 2020
@ofborg ofborg bot removed the 6.topic: python label Feb 12, 2020
@JeffLabonte JeffLabonte force-pushed the JeffLabonte:python3_digi-xbee branch from 717447c to 29cc593 Feb 12, 2020
@JeffLabonte
Copy link
Contributor Author

@JeffLabonte JeffLabonte commented Feb 12, 2020

Everything should resolved right now. Thank you for your review!

Copy link
Contributor

@jonringer jonringer left a comment

to avoid:

arning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/c7nw0sfjgdhv66d1fa9rvny5k4h4f26r-python2.7-digi-xbee-1.3.0.drv' failed with exit code 1; last 10 log lines:
  adding 'digi_xbee-1.3.0.dist-info/top_level.txt'
  adding 'digi_xbee-1.3.0.dist-info/RECORD'
  removing build/bdist.linux-x86_64/wheel
  Finished executing setuptoolsBuildPhase
  installing
  Executing pipInstallPhase
  /build/digi-xbee-1.3.0/dist /build/digi-xbee-1.3.0
  DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
  Processing ./digi_xbee-1.3.0-py2-none-any.whl
  ERROR: Package 'digi-xbee' requires a different Python: 2.7.17 not in '>=3'
cannot build derivation '/nix/store/4gcrahskwpprqz9xs7p8wpsfd28xjrv2-env.drv': 1 dependencies couldn't be built
[7 built (1 failed), 3 copied (1.6 MiB), 0.3 MiB DL]
error: build of '/nix/store/4gcrahskwpprqz9xs7p8wpsfd28xjrv2-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/79688
1 package failed to build:
python27Packages.digi-xbee
@JeffLabonte JeffLabonte force-pushed the JeffLabonte:python3_digi-xbee branch from 29cc593 to f839c63 Feb 12, 2020
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commits LGTM

[6 built, 2 copied (1.0 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79688
5 package built:
python27Packages.srp python37Packages.digi-xbee python37Packages.srp python38Packages.digi-xbee python38Packages.srp

would like more tests, but understandably difficult to do in sandboxed environments

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 12, 2020

@GrahamcOfBorg build python27Packages.srp python37Packages.digi-xbee python37Packages.srp python38Packages.digi-xbee python38Packages.srp

@jonringer jonringer merged commit b67006f into NixOS:master Feb 12, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.srp, python37Packages.digi-xbee, python37Packages.srp, python38Packages.digi-xbee, python38Packages.srp on aarch64-linux Success
Details
python27Packages.srp, python37Packages.digi-xbee, python37Packages.srp, python38Packages.digi-xbee, python38Packages.srp on x86_64-darwin Success
Details
python27Packages.srp, python37Packages.digi-xbee, python37Packages.srp, python38Packages.digi-xbee, python38Packages.srp on x86_64-linux Success
Details
@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 12, 2020

@JeffLabonte congrats on your first PR :)

@JeffLabonte
Copy link
Contributor Author

@JeffLabonte JeffLabonte commented Feb 12, 2020

Thank you @jonringer ! Thank you for your time, your patience and your knowledge! Hope to work again together!

JeffLabonte added a commit to JeffLabonte/nixpkgs that referenced this pull request Feb 26, 2020
maintainers: add jefflabonte

(cherry picked from commit d5e52ad)
Reason: my name is part of the maintainer list of brave
@JeffLabonte JeffLabonte mentioned this pull request Feb 26, 2020
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.