Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skawarePackages: support static builds via pkgsStatic #79705

Merged

Conversation

@Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Feb 10, 2020

Most of the skaware packages already build just fine with pkgsStatic,
however the wrapper scripts for execline and stdnotify-wrapper needed
the -lskarlib argument to go at the end.

utmps and nsss still fail with this error:

exec ./tools/install.sh -D -m 600 utmps-utmpd /bin/utmps-utmpd
/build/utmps-0.0.3.1/tools/install.sh: line 48: can't create /bin/utmps-utmpd.tmp.479: Permission denied
make: *** [Makefile:121: /bin/utmps-utmpd] Error 1
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@alyssais
Copy link
Member

@alyssais alyssais commented Mar 12, 2020

however the wrapper scripts for execline and stdnotify-wrapper needed
the -lskarlib argument to go at the end.

Interesting. Why?

@Profpatsch
Copy link
Member Author

@Profpatsch Profpatsch commented Mar 22, 2020

Interesting. Why?

Something about how arguments to CC are order dependent and missing symbols when linking (I’ve forgotten by now honestly and I kinda don’t want my brain to store this horrible information :( )

@Profpatsch Profpatsch force-pushed the Profpatsch:skawarePackages-mostly-fix-for-pkgsStatic branch from 95fdf9f to 61a0acf Mar 22, 2020
@Profpatsch
Copy link
Member Author

@Profpatsch Profpatsch commented Mar 22, 2020

Rebased onto #83162

@GrahamcOfBorg build pkgsStatic.skawarePackages

@ofborg ofborg bot requested a review from pmahoney Mar 22, 2020
@FRidh FRidh added this to Needs review in Static builds Mar 29, 2020
Most of the skaware packages already build just fine with pkgsStatic,
however the wrapper scripts for execline and stdnotify-wrapper needed
the `-lskarlib` argument to go at the end.

`utmps` and `nsss` still fail with this error:

```
exec ./tools/install.sh -D -m 600 utmps-utmpd /bin/utmps-utmpd
/build/utmps-0.0.3.1/tools/install.sh: line 48: can't create /bin/utmps-utmpd.tmp.479: Permission denied
make: *** [Makefile:121: /bin/utmps-utmpd] Error 1
```
@Profpatsch Profpatsch force-pushed the Profpatsch:skawarePackages-mostly-fix-for-pkgsStatic branch from 61a0acf to 16cc7a3 Mar 29, 2020
@Profpatsch
Copy link
Member Author

@Profpatsch Profpatsch commented Mar 29, 2020

Rebased after merging the other PR
@GrahamcOfBorg build pkgsStatic.skawarePackages

@Profpatsch Profpatsch merged commit bf3bd5f into NixOS:master Mar 29, 2020
3 checks passed
3 checks passed
pkgsStatic.skawarePackages on x86_64-darwin No attempt
Details
pkgsStatic.skawarePackages on aarch64-linux Success
Details
pkgsStatic.skawarePackages on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Static builds
Needs review
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.