Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ispc: 1.10.0 -> 1.12.0 #79746

Closed
wants to merge 1 commit into from
Closed

ispc: 1.10.0 -> 1.12.0 #79746

wants to merge 1 commit into from

Conversation

@athas
Copy link
Contributor

@athas athas commented Feb 10, 2020

Motivation for this change

newer=better

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@alyssais alyssais left a comment

You need to update the checksum. This won’t actually have changed anything.

@athas athas force-pushed the athas:ispc-1.12.0 branch from f15b1bd to 58b9108 Mar 13, 2020
@athas
Copy link
Contributor Author

@athas athas commented Mar 13, 2020

Ah, right, of course. That gave rise to some more problems that I had to address (#39687 is relevant).

@athas athas force-pushed the athas:ispc-1.12.0 branch from 58b9108 to 6fffafc Mar 13, 2020
@athas athas requested a review from alyssais Apr 16, 2020
@athas
Copy link
Contributor Author

@athas athas commented Apr 24, 2020

Superceded by #85946.

@athas athas closed this Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.