Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash-my-aws: add runtime dependencies #79752

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@tomberek
Copy link
Contributor

@tomberek tomberek commented Feb 10, 2020

Motivation for this change

Missing runtime dependencies. Is there a canonical location for these, or just place the dependency paths into a comment for the "runtime-dependency hash search" to find?

Things done

Added column and coreutils as dependencies.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@danbst
Copy link
Contributor

@danbst danbst commented Feb 14, 2020

hmm. By placing those to propagatedBuildInputs you already declare that those must be runtime dependencies:

$ cat result/nix-support/propagated-build-inputs 
/nix/store/8hk4n13ab6x2bw9ccsfj4c04ks2z5jwl-awscli-1.16.266 /nix/store/r9ind70jisam7yj7bjgc9vm6d1rqgdjm-jq-1.6-dev /nix/store/bgpkj0876waccxc1vrxj76b9kvvv21hd-bash-interactive-4.4-p23-dev 

However aws isn't added to profile/bin after nix-env installation. I think that bma has to be wrapped and PATH must be adjusted to include aws, jq and so on.

As for coreutils, can you add a comment which commands are used there?

cc @vcunat as a more savant maintainer: is wrapping an executable with custom PATH a correct solution here?

@danbst
Copy link
Contributor

@danbst danbst commented Feb 14, 2020

(also I've noticed you made a PR from master branch. It is fine now, but still better to rebase PR to a separate branch)

@vcunat
Copy link
Member

@vcunat vcunat commented Feb 14, 2020

Yes. I don't know this particular case, but wrapping executables to extend $PATH sounds good. Typically wrapProgram is used to do that. (You might not even need such tools *Inputs after that, but it shouldn't matter.)

@stale
Copy link

@stale stale bot commented Aug 12, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale label Aug 12, 2020
wrap PATH to provide runtime utilities
@tomberek tomberek force-pushed the tomberek:master branch from 6b1e7c6 to 66c5b25 Aug 14, 2020
@stale stale bot removed the 2.status: stale label Aug 14, 2020
@tomberek
Copy link
Contributor Author

@tomberek tomberek commented Aug 14, 2020

Updated to use wrapProgram

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.