Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs: pin to 12.x by default #79753

Closed
wants to merge 1 commit into from

Conversation

@disassembler
Copy link
Member

disassembler commented Feb 10, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@disassembler disassembler force-pushed the disassembler:pin-nodejs-12 branch from 3f10a36 to a2ffd56 Feb 10, 2020
@disassembler
Copy link
Member Author

disassembler commented Feb 10, 2020

This is not going in release 20.03. It will be part of 20.09.

@marsam
Copy link
Contributor

marsam commented Feb 11, 2020

I think we should also make nodePackages to use nodejs-12_x

Copy link
Contributor

raboof left a comment

Some comments, and it seems this PR has a merge conflict so needs a rebase.

@@ -2,7 +2,7 @@

{pkgs ? import <nixpkgs> {
inherit system;
}, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-13_x"}:
}, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-8_x"}:

This comment has been minimized.

Copy link
@raboof

raboof Apr 11, 2020

Contributor

This seems wrong?

@@ -8941,13 +8941,13 @@ let
sha512 = "bsTwuIg/BZZK/vreVTYYbSWoe2F+71P7K5QGEX+pT250DZbfU1MQ5prOKpPR+LL6uWKK3KMwMCAS74QB3Um1uw==";
};
};
"caniuse-lite-1.0.30001025" = {
"caniuse-lite-1.0.30001027" = {

This comment has been minimized.

Copy link
@raboof

raboof Apr 11, 2020

Contributor

Are these changes relevant here?

@@ -4677,7 +4677,7 @@ in

nixnote2 = libsForQt5.callPackage ../applications/misc/nixnote2 { };

nodejs = hiPrio nodejs-10_x;
nodejs = hiPrio nodejs-12_x;

This comment has been minimized.

Copy link
@raboof

raboof Apr 11, 2020

Contributor

👍 I would like this, too. Perhaps also update nodejs-slim?

@prusnak
Copy link
Member

prusnak commented May 14, 2020

Seems this is superseded by #85764

@prusnak prusnak closed this May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.