Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noto-fonts{,-extra,-cjk}: update #79762

Merged
merged 2 commits into from Feb 29, 2020
Merged

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Feb 10, 2020

Motivation for this change

It's been over a year since the Noto package has been updated, so I refactored and bumped it. This new version adds support for multiple new Unicode scripts previously not covered in NixOS to my knowledge, including Siddham and Tangut. The license also changed to SIL OFL 1.1.

@GrahamcOfBorg build noto-fonts noto-fonts-extra noto-fonts-cjk

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 10, 2020

Agh, yet another outdated sha256 error.

@GrahamcOfBorg build noto-fonts noto-fonts-extra noto-fonts-cjk

For what it's worth, a lot of the existing fonts also had their coverage expanded quite significantly, e.g. the Math font.

@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 10, 2020

looks like a timeout?

@GrahamcOfBorg build noto-fonts

@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 10, 2020

@GrahamcOfBorg build noto-fonts-extra

@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 10, 2020

@GrahamcOfBorg build noto-fonts-cjk

@emilazy emilazy force-pushed the emilazy:update-noto-fonts branch 3 times, most recently from 4b511df to 8499d91 Feb 10, 2020
@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 11, 2020

@GrahamcOfBorg build noto-fonts noto-fonts-extra noto-fonts-cjk

@emilazy emilazy force-pushed the emilazy:update-noto-fonts branch from 8499d91 to b0e9b47 Feb 11, 2020
@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 11, 2020

Fixed output derivations are the bane of my existence.

@GrahamcOfBorg build noto-fonts noto-fonts-extra

@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 11, 2020

@GrahamcOfBorg build noto-fonts-cjk

@emilazy emilazy force-pushed the emilazy:update-noto-fonts branch from b0e9b47 to 254077b Feb 11, 2020
@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 11, 2020

Updated with stdenvNoCC.

@GrahamcOfBorg build noto-fonts noto-fonts-extra noto-fonts-cjk

@ofborg ofborg bot requested a review from Mathnerd314 Feb 11, 2020
Copy link
Contributor

@Mathnerd314 Mathnerd314 left a comment

Alright, looks good to me (I didn't bother testing it since they're just fonts). There's also a Noto Serif CJK TTC available from the middle of https://www.google.com/get/noto/help/cjk/ but it doesn't seem to be versioned.

@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 12, 2020

Good catch, though to be honest, there's almost no point to using the Noto CJK fonts at all, since they're almost identical to Source Han (see Noto Sans CJK Differences in the Source Han Sans readme).

@Mathnerd314
Copy link
Contributor

@Mathnerd314 Mathnerd314 commented Feb 15, 2020

Fedora made Noto CJK the default: https://fedoraproject.org/wiki/Changes/CJKDefaultFontsToNoto, changing it from Source Han. But of course having all the fonts packaged would be best; I think Source Han Mono is distinct from Noto Sans Mono CJK.

@emilazy emilazy force-pushed the emilazy:update-noto-fonts branch from 254077b to 1627382 Feb 23, 2020
@ofborg ofborg bot requested a review from Mathnerd314 Feb 23, 2020
@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 23, 2020

Vaguely planning to add Noto CJK {Serif,Mono} when I have the time, but this builds properly now.

@yegortimoshenko yegortimoshenko force-pushed the emilazy:update-noto-fonts branch from 1627382 to cf792da Feb 29, 2020
@ofborg ofborg bot requested a review from Mathnerd314 Feb 29, 2020
@yegortimoshenko
Copy link
Member

@yegortimoshenko yegortimoshenko commented Feb 29, 2020

I've tested Noto Sans, Noto Color Emoji and Noto Sans CJK. Thank you~

@yegortimoshenko yegortimoshenko merged commit 8193658 into NixOS:master Feb 29, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
noto-fonts-cjk on aarch64-linux Success
Details
noto-fonts-cjk on x86_64-linux Success
Details
@Mathnerd314 Mathnerd314 mentioned this pull request Mar 1, 2020
4 of 10 tasks complete
@emilazy emilazy deleted the emilazy:update-noto-fonts branch Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.