Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] aspell: 0.60.6.1 -> 0.60.8 #79772

Merged
merged 1 commit into from Apr 15, 2020

Conversation

@wamserma
Copy link
Contributor

@wamserma wamserma commented Feb 10, 2020

Motivation for this change

See http://aspell.net/aspell-0.60.8.txt for release information.
(#71242)

The fix for CVE-2019-20433 may break compatibility for some
applications, hence a version bump instead of adding a patch.

Also: backport of 648678f

Fixes #79719
Fixes #73616

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
See http://aspell.net/aspell-0.60.8.txt for release information.
(#71242)

The fix for CVE-2019-20433 may break compatibility for some
applications, hence a version bump instead of adding a patch.

Also: backport of 648678f
@wamserma wamserma changed the base branch from master to release-19.09 Feb 10, 2020
@veprbl veprbl changed the title aspell: 0.60.6.1 -> 0.60.8 (security, backport) [19.09] aspell: 0.60.6.1 -> 0.60.8 Feb 10, 2020
@risicle
Copy link
Contributor

@risicle risicle commented Feb 12, 2020

Seems sensible and WFM on non-nixos linux x86_64 (obviously not done a full rebuild though)

@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Apr 15, 2020

@risicle any chance of getting this merged? 19.09 is not EOL yet

@risicle
Copy link
Contributor

@risicle risicle commented Apr 15, 2020

@GrahamcOfBorg build aspell abiword

@risicle
Copy link
Contributor

@risicle risicle commented Apr 15, 2020

@risicle risicle merged commit b67bc34 into NixOS:release-19.09 Apr 15, 2020
20 checks passed
20 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
abiword, aspell on aarch64-linux Success
Details
abiword, aspell on x86_64-linux Success
Details
aspell on aarch64-linux Success
Details
aspell on x86_64-linux Success
Details
aspell, aspell.passthru.tests on aarch64-linux Success
Details
aspell, aspell.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="24ad802"; rev="24ad80200f6edc99a64c0c242165e530496d07d4"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="24ad802"; rev="24ad80200f6edc99a64c0c242165e530496d07d4"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="24ad802"; rev="24ad80200f6edc99a64c0c242165e530496d07d4"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="24ad802"; rev="24ad80200f6edc99a64c0c242165e530496d07d4"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="24ad802"; rev="24ad80200f6edc99a64c0c242165e530496d07d4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="24ad802"; rev="24ad80200f6edc99a64c0c242165e530496d07d4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="24ad802"; rev="24ad80200f6edc99a64c0c242165e530496d07d4"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@wamserma wamserma deleted the wamserma:fix-aspell-CVEs-backport branch Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.