Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gunicorn: add 19.x branch for python2.7 support #79782

Merged
merged 1 commit into from Feb 11, 2020

Conversation

@mmilata
Copy link
Member

@mmilata mmilata commented Feb 10, 2020

The nixos/moinmoin module uses gunicorn, however the 20.0 version dropped python2 support which broke the module as there's no python3 port planned for moinmoin: http://moinmo.in/Python3

Motivation for this change

nix-build nixos/tests/moinmoin.nix fails

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @FRidh @jonringer

@mmilata mmilata requested review from FRidh and jonringer as code owners Feb 10, 2020
The nixos/moinmoin module uses gunicorn, however the 20.0 version
dropped python2 support which broke the module as there's no python3
port planned for moinmoin: http://moinmo.in/Python3
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM

https://github.com/NixOS/nixpkgs/pull/79782
5 package built:
python27Packages.flask-sockets python27Packages.gevent-socketio python27Packages.gevent-websocket python27Packages.gunicorn python27Packages.runway-python
@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 11, 2020

the commit msg should be something similar to:

python2Packages.gunicorn: freeze at 19.10.0

but I should have caught that in my previous review

@jonringer jonringer merged commit b86f4d5 into NixOS:master Feb 11, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@mmilata
Copy link
Member Author

@mmilata mmilata commented Feb 11, 2020

@jonringer thanks! Will keep that in mind next time.

@mmilata mmilata deleted the mmilata:gunicorn-python27 branch Feb 11, 2020
@jonringer jonringer mentioned this pull request Feb 11, 2020
1 of 10 tasks complete
@mmilata mmilata mentioned this pull request Feb 11, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.