Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-pack: 0.8.1 -> 0.9.1 #79824

merged 1 commit into from Feb 12, 2020

wasm-pack: 0.8.1 -> 0.9.1 #79824

merged 1 commit into from Feb 12, 2020


Copy link

@dhl dhl commented Feb 11, 2020

Motivation for this change

Updating wasm-pack to a new minor release.

The updated expression also replaced OpenSSL with LibreSSL to work around a race condition raised in this issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits

A template project was generated and built successfully with the following:
wasm-pack new hello-wasm
cd hello-wasm
wasm-pack build

Output for wasm-pack new hello-wasm:

$ wasm-pack new hello-wasm
[INFO]: Installing cargo-generate...
 Generating a new rustwasm project with name 'hello-wasm'...
 Creating project called `hello-wasm`...
 Done! New project created /tmp/tmp.HiLjhbsbrS/hello-wasm
[INFO]: 馃悜 Generated new project at /hello-wasm

Output for wasm-pack build:

[INFO]: Checking for the Wasm target...
[INFO]: Compiling to Wasm...
   Compiling proc-macro2 v1.0.8
   Compiling unicode-xid v0.2.0
   Compiling log v0.4.8
   Compiling syn v1.0.14
   Compiling wasm-bindgen-shared v0.2.58
   Compiling cfg-if v0.1.10
   Compiling lazy_static v1.4.0
   Compiling bumpalo v3.2.0
   Compiling wasm-bindgen v0.2.58
   Compiling quote v1.0.2
   Compiling wasm-bindgen-backend v0.2.58
   Compiling wasm-bindgen-macro-support v0.2.58
   Compiling wasm-bindgen-macro v0.2.58
   Compiling console_error_panic_hook v0.1.6
   Compiling hello-wasm v0.1.0 (/tmp/tmp.HiLjhbsbrS/hello-wasm)
warning: function is never used: `set_panic_hook`
 --> src/
1 | pub fn set_panic_hook() {
  |        ^^^^^^^^^^^^^^
  = note: `#[warn(dead_code)]` on by default

    Finished release [optimized] target(s) in 19.33s
[INFO]: Installing wasm-bindgen...
[INFO]: Optimizing wasm binaries with `wasm-opt`...
[INFO]: Optional fields missing from Cargo.toml: 'description', 'repository', and 'license'. These are not necessary, but recommended
[INFO]: :-) Done in 19.41s
[INFO]: :-) Your wasm pkg is ready to publish at /tmp/tmp.HiLjhbsbrS/hello-wasm/pkg.
@dhl dhl force-pushed the dhl:wasm-pack-0.9.1 branch from b2a778a to 40297b7 Feb 12, 2020
@dhl dhl requested a review from FRidh Feb 12, 2020
@FRidh FRidh merged commit e6b2d88 into NixOS:master Feb 12, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
grahamcofborg-eval ^.^!
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
grahamcofborg-eval-check-meta config.nix: checkMeta = true
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
grahamcofborg-eval-package-list nix-env -qa --json --file .
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
wasm-pack on aarch64-linux Success
wasm-pack on x86_64-linux Success
@dhl dhl deleted the dhl:wasm-pack-0.9.1 branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.