Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argocd: init at 1.4.2 #79846

Merged
merged 1 commit into from Feb 13, 2020
Merged

argocd: init at 1.4.2 #79846

merged 1 commit into from Feb 13, 2020

Conversation

@shahrukh330
Copy link
Contributor

@shahrukh330 shahrukh330 commented Feb 11, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@shahrukh330 shahrukh330 requested a review from kalbasit Feb 11, 2020
@ofborg ofborg bot requested a review from ehmry Feb 11, 2020
@shahrukh330 shahrukh330 force-pushed the shahrukh330:master branch from 60f4b56 to de3c214 Feb 11, 2020
@shahrukh330 shahrukh330 changed the title argocd-cli: init at 1.3.0 argocd: init at 1.3.0 Feb 11, 2020
@shahrukh330 shahrukh330 changed the title argocd: init at 1.3.0 argocd: init at 1.4.1 Feb 12, 2020
@shahrukh330 shahrukh330 force-pushed the shahrukh330:master branch from de3c214 to f58f7bc Feb 12, 2020
@shahrukh330 shahrukh330 changed the title argocd: init at 1.4.1 argocd: init at 1.4.2 Feb 12, 2020
@ofborg ofborg bot requested a review from kalbasit Feb 12, 2020
@@ -0,0 +1,3058 @@
diff --git a/Gopkg.lock b/Gopkg.lock

This comment has been minimized.

@kalbasit

kalbasit Feb 13, 2020
Member

Is generating this patch reproducible? Should we include an update.sh in this directory to get it to generate a patch on the fly?

This comment has been minimized.

@shahrukh330

shahrukh330 Feb 13, 2020
Author Contributor

This is not reproducible at the moment. I had to manually fix broken dependencies in go.mod after doing go mod init

This comment has been minimized.

@kalbasit

kalbasit Feb 13, 2020
Member

Fair enough. Let's submit the patch to the upstream project then.

Shahrukh Khan Shahrukh Khan
@shahrukh330 shahrukh330 force-pushed the shahrukh330:master branch from f58f7bc to 6d9abce Feb 13, 2020
@kalbasit
Copy link
Member

@kalbasit kalbasit commented Feb 13, 2020

@GrahamcOfBorg build argocd

@ofborg ofborg bot requested a review from kalbasit Feb 13, 2020
@kalbasit kalbasit merged commit be16359 into NixOS:master Feb 13, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
argocd on aarch64-linux Success
Details
argocd on x86_64-darwin Success
Details
argocd on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.