Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: install man pages #79850

Closed
wants to merge 1 commit into from
Closed

cargo: install man pages #79850

wants to merge 1 commit into from

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Feb 11, 2020

Motivation for this change

I thought about doing a seperate output for these, but they're tiny
compared to the size of the binary, so there's no point.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
I thought about doing a seperate output for these, but they're tiny
compared to the size of the binary, so there's no point.
@FRidh
Copy link
Member

@FRidh FRidh commented Feb 12, 2020

please target staging

@FRidh FRidh added this to WIP in Staging via automation Feb 12, 2020
@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Feb 12, 2020

@andir can merge this together with #79930 into master. The other PR needs to go to master soon.

@andir andir mentioned this pull request Feb 12, 2020
0 of 10 tasks complete
@andir
Copy link
Member

@andir andir commented Feb 12, 2020

Has been merged to master as part of #79930. Closing this.

@andir andir closed this Feb 12, 2020
Staging automation moved this from WIP to Done Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.