Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fscrypt-experimental: 0.2.5 -> 0.2.6 #79853

Merged
merged 1 commit into from Feb 12, 2020
Merged

fscrypt-experimental: 0.2.5 -> 0.2.6 #79853

merged 1 commit into from Feb 12, 2020

Conversation

@primeos
Copy link
Member

@primeos primeos commented Feb 11, 2020

Motivation for this change

Unfortunately this requires some hacks atm, but the result should be fine.
Update: Ran a few tests and it seems fine so far :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@primeos primeos force-pushed the primeos:fscrypt branch from ea1915f to 5c6444e Feb 11, 2020
@ofborg ofborg bot requested a review from kalbasit Feb 11, 2020
@primeos primeos merged commit ac758ca into NixOS:master Feb 12, 2020
16 checks passed
16 checks passed
fscrypt-experimental on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
fscrypt-experimental on aarch64-linux Success
Details
fscrypt-experimental on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Feb 13, 2020
Changelog: https://github.com/google/fscrypt/releases/tag/v0.2.6
(cherry picked from commit ac758ca)
primeos added a commit that referenced this pull request Feb 15, 2020
Changelog: https://github.com/google/fscrypt/releases/tag/v0.2.6
(cherry picked from commit ac758ca)
Reason: Since NixOS 20.03 will ship with Linux kernel 5.4 by default,
the new support for v2 kernel encryption policies is useful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.